Skip to content

Conversation

@seyfeb
Copy link
Collaborator

@seyfeb seyfeb commented Dec 19, 2023

Topic and Scope

Add missing translatable string

Closes #2001

Concerns/issues

None

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

@seyfeb seyfeb added javascript Pull requests that update Javascript code Frontend Issue or PR related to the frontend code labels Dec 19, 2023
@seyfeb
Copy link
Collaborator Author

seyfeb commented Dec 19, 2023

/approve

Copy link
Collaborator

@nextcloud-cookbook-bot nextcloud-cookbook-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by GitHub action on behalf of /approve

@codecov
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (07f3e94) 80.07% compared to head (47cd1cb) 80.07%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2015   +/-   ##
=======================================
  Coverage   80.07%   80.07%           
=======================================
  Files          92       92           
  Lines        2650     2650           
=======================================
  Hits         2122     2122           
  Misses        528      528           
Flag Coverage Δ
integration 21.43% <ø> (ø)
migration 5.69% <ø> (ø)
unittests 57.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

Test Results

     12 files     572 suites   1m 31s ⏱️
   552 tests    552 ✔️ 0 💤 0
2 208 runs  2 207 ✔️ 1 💤 0

Results for commit 47cd1cb.

@seyfeb
Copy link
Collaborator Author

seyfeb commented Dec 19, 2023

/backport main-0.10.x

@seyfeb seyfeb merged commit f65f024 into master Dec 19, 2023
@seyfeb seyfeb deleted the fix/2001-add-missing-translation branch December 19, 2023 18:39
@christianlupus christianlupus added the manual-backport-required The backpoort needs to be carried out manually. label Dec 19, 2023
@seyfeb
Copy link
Collaborator Author

seyfeb commented Dec 19, 2023

/cb-backport main-0.10.x

@seyfeb
Copy link
Collaborator Author

seyfeb commented Dec 19, 2023

/backport to main-0.10.x

@backportbot-nextcloud
Copy link

The backport to main-0.10.x failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout main-0.10.x
git pull origin main-0.10.x

# Create the new backport branch
git checkout -b fix/foo-main-0.10.x

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-main-0.10.x

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@christianlupus christianlupus removed the manual-backport-required The backpoort needs to be carried out manually. label Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-request Frontend Issue or PR related to the frontend code javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing translation for "Create new recipe!"

4 participants