-
Notifications
You must be signed in to change notification settings - Fork 102
Fix/1408 more consistent UI timer #2014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2014 +/- ##
=======================================
Coverage 80.07% 80.07%
=======================================
Files 92 92
Lines 2650 2650
=======================================
Hits 2122 2122
Misses 528 528
Flags with carried forward coverage won't be shown. Click here to find out more. |
Test Results 12 files 572 suites 1m 30s ⏱️ Results for commit 948e229. ♻️ This comment has been updated with latest results. |
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
…ting Signed-off-by: Sebastian Fey <[email protected]>
…f only minutes are set) Signed-off-by: Sebastian Fey <[email protected]>
…t show 1h0m0s) Signed-off-by: Sebastian Fey <[email protected]>
…itially set. Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
2d921ff to
948e229
Compare
Signed-off-by: Sebastian Fey <[email protected]> Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]> Signed-off-by: Christian Wolf <[email protected]>
948e229 to
7b55fb0
Compare
christianlupus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I have not verified every single line but it seems o work out well.
Topic and Scope
H:MMfrom labeln(...)function available in JSCloses #1408. Closes #1747
Concerns/issues
This currently only supports translations to left-to-right languages, i.e., first hours, then minutes, then seconds.
Formal requirements
There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.