Skip to content

Fix/1966 change abort icon during editing #1971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christianlupus merged 3 commits into from
Dec 13, 2023
Merged

Fix/1966 change abort icon during editing #1971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
009192b
fix: Replace cancel icon in recipe editing mode
seyfeb Dec 12, 2023
afb83e5
chore: Update CHANGELOG
seyfeb Dec 12, 2023
4b8f9fe
Make eslint happy
christianlupus Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
[#1963](https://github.com/nextcloud/cookbook/pull/1963) @seyfeb
- Fix searching recipes by string.
[#1965](https://github.com/nextcloud/cookbook/pull/1965) @seyfeb
- Replace eye icon with close icon for cancelling recipe edit
[#1971](https://github.com/nextcloud/cookbook/pull/1971) @seyfeb

### Maintenance
- Add PHP lint checker to ensure valid (legacy) PHP syntax
Expand Down
8 changes: 4 additions & 4 deletions src/components/AppControls/AppControls.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,15 +93,15 @@
<NcActionInput
icon="icon-quota"
:value="filterValue"
@update:value="updateFilters"
aria-label="Filter current recipes"
@update:value="updateFilters"
>
<template #icon>
<FilterIcon :size="20" />
</template>
{{ t('cookbook', 'Filter') }}
</NcActionInput>
<NcActionInput @submit="search" aria-label="Search recipes">
<NcActionInput aria-label="Search recipes" @submit="search">
<template #icon>
<SearchIcon :size="20" />
</template>
Expand Down Expand Up @@ -142,7 +142,7 @@
"
:size="20"
/>
<eye-icon v-else :size="20" />
<AbortIcon v-else :size="20" />
</template>
</NcActionButton>
<NcActionButton
Expand Down Expand Up @@ -206,7 +206,7 @@ import LoadingIcon from 'icons/Loading.vue';
import CheckmarkIcon from 'icons/Check.vue';
import FilterIcon from 'icons/FilterOutline.vue';
import PrinterIcon from 'icons/Printer.vue';
import EyeIcon from 'icons/Eye.vue';
import AbortIcon from 'icons/Close.vue';
import ContentDuplicateIcon from 'icons/ContentDuplicate.vue';
import SearchIcon from 'icons/Magnify.vue';

Expand Down