Skip to content

Conversation

@christianlupus
Copy link
Collaborator

Topic and Scope

Closes #1936

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

@codecov
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #1947 (c92ad04) into main-0.10.x (abaf209) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           main-0.10.x    #1947   +/-   ##
============================================
  Coverage        80.07%   80.07%           
============================================
  Files               92       92           
  Lines             2650     2650           
============================================
  Hits              2122     2122           
  Misses             528      528           
Flag Coverage Δ
integration 21.43% <ø> (ø)
migration 5.69% <ø> (ø)
unittests 57.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@christianlupus
Copy link
Collaborator Author

/approve

Copy link
Collaborator

@nextcloud-cookbook-bot nextcloud-cookbook-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by GitHub action on behalf of /approve

@github-actions
Copy link

github-actions bot commented Dec 7, 2023

Test Results

     27 files  1 287 suites   5m 23s ⏱️
   552 tests    552 ✔️ 0 💤 0
4 968 runs  4 967 ✔️ 1 💤 0

Results for commit c92ad04.

@christianlupus christianlupus merged commit 7fce1ee into main-0.10.x Dec 7, 2023
@christianlupus christianlupus deleted the fix/1936-translate-missing-string branch December 7, 2023 12:17
@christianlupus
Copy link
Collaborator Author

/cb-backport master

1 similar comment
@christianlupus
Copy link
Collaborator Author

/cb-backport master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants