Skip to content

Conversation

@seyfeb
Copy link
Collaborator

@seyfeb seyfeb commented Dec 4, 2023

Topic and Scope

Fixes flashing in SearchResults. Closes 1891.

Concerns/issues

None

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

Signed-off-by: Sebastian Fey <[email protected]>
@seyfeb seyfeb force-pushed the fix/1891-Nasty-flashing-when-finishing-XHR-requests branch from a935fd2 to 4e0e25e Compare December 4, 2023 16:28
@seyfeb
Copy link
Collaborator Author

seyfeb commented Dec 4, 2023

/approve

Copy link
Collaborator

@nextcloud-cookbook-bot nextcloud-cookbook-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by GitHub action on behalf of /approve

@github-actions
Copy link

github-actions bot commented Dec 4, 2023

Test Results

     27 files  1 287 suites   5m 25s ⏱️
   552 tests    552 ✔️ 0 💤 0
4 968 runs  4 967 ✔️ 1 💤 0

Results for commit 4e0e25e.

@seyfeb seyfeb merged commit a751621 into nextcloud:master Dec 4, 2023
@christianlupus
Copy link
Collaborator

Kannst du bitte noch einen zweiten PR machen, der gehen dem main-0.10.x branch läuft? Beide Zweige sind an der Stelle noch identisch, also sollte es keine Änderungen benötigen.

@seyfeb
Copy link
Collaborator Author

seyfeb commented Dec 4, 2023

See #1920

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants