Skip to content

Conversation

@rakekniven
Copy link
Member

Reported at Transifex

Reported at Transifex

Signed-off-by: rakekniven <[email protected]>
@rakekniven rakekniven requested a review from seyfeb December 1, 2023 15:27
@github-actions
Copy link

github-actions bot commented Dec 1, 2023

Test Results

     27 files  1 242 suites   5m 25s ⏱️
   510 tests    510 ✔️ 0 💤 0
4 590 runs  4 589 ✔️ 1 💤 0

Results for commit 923fb77.

Copy link
Collaborator

@christianlupus christianlupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@christianlupus
Copy link
Collaborator

I have to fix a bit the code styling in order to get that done. Will have to be done on a desktop not mobile.

@christianlupus christianlupus added this to the Release 0.10.3 milestone Dec 1, 2023
@christianlupus christianlupus self-assigned this Dec 1, 2023
@codecov
Copy link

codecov bot commented Dec 2, 2023

Codecov Report

Merging #1907 (f11f053) into master (fd94a82) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1907   +/-   ##
=======================================
  Coverage   79.55%   79.55%           
=======================================
  Files          89       89           
  Lines        2582     2582           
=======================================
  Hits         2054     2054           
  Misses        528      528           
Flag Coverage Δ
integration 21.99% <ø> (ø)
migration 5.84% <ø> (ø)
unittests 55.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
@christianlupus christianlupus merged commit d587b3e into master Dec 2, 2023
@christianlupus christianlupus deleted the rakekniven-patch-1 branch December 2, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants