WIP: Prepare Vue.js 2 -> 3 upgrade, several bugfixes and features #1896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seyfeb
added
dependencies
seyfeb
force-pushed
the
chore/prepare-vue-upgrade
branch
from
bd4eba9 to
3c35018
Compare
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
…osition api Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
…api by splitting into vue file and composable to replace mixin Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
…Group) Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
… api Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
…ponents cannot be used as a message bus in Vue.js 3 anymore Signed-off-by: Sebastian Fey <[email protected]>
…rols` to the store instead of emitting event Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
…pup` Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
…otes and require semicolons in JS code. Run stylelint and prettier to fix style Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
seyfeb
force-pushed
the
chore/prepare-vue-upgrade
branch
from
3c35018 to
2c6ed47
Compare
…nputField`, `EditInputGroup` and `useSuggestionsPopup`. Signed-off-by: Sebastian Fey <[email protected]>
…e .eslintrc Signed-off-by: Sebastian Fey <[email protected]>
seyfeb
force-pushed
the
chore/prepare-vue-upgrade
branch
from
457ed93 to
e74ff0c
Compare
… prevent some flickering (nextcloud#1891) Signed-off-by: Sebastian Fey <[email protected]>
…events flickering on fast connections when data is loaded. Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
…` (see nextcloud#1891) Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
… available from store in `RecipeEdit`. Signed-off-by: Sebastian Fey <[email protected]>
…n filtering `RecipeList`, ignoring accents and some letters. Closes nextcloud#1870. Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
…n `LazyPicture`. Signed-off-by: Sebastian Fey <[email protected]>
…and save clone of existing recipe. Also fixes issue with `AppControls` when editing recipe. Closes nextcloud#1867. Signed-off-by: Sebastian Fey <[email protected]>
seyfeb
changed the title
…pgrade # Conflicts: # CHANGELOG.md # src/components/RecipeList.vue # src/components/RecipeView.vue # src/components/SettingsDialog.vue
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Collaborator
|
This PR is not yet working smoothly. I managed to get it on par with the current master branch at least such that it could be merged technically. Quite some of the changes made since the branch creation have been manually checked/incorporated by me. However, not everything is running smoothly. I have seen two still present issues, maybe more are yet hidden as I just quickly tested the merged version:
For now, I am done (still feeling ill) and will have to rest a bit. Sorry, no better results. |
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
christianlupus
approved these changes
Dec 3, 2023
Collaborator
christianlupus
left a comment
christianlupus
left a comment
There was a problem hiding this comment.
Having clicked back and forth in the version, with the fixes applied, I see no breaks anymore in my dev environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Topic and Scope
Soon an update to vue 3 is required. (#752)
This PR does some things in preparation:
mittevent bus library.vuefilesRecipeEdit,RecipeList, andRecipeViewCloses #1079, closes #1870, closes #1867
The first approach to tackle at least partially #1891
Known Issues
None so far
Impressions
Filtering
Cloning
Loading indicator (delayed)
Formal requirements
There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.