Skip to content

Conversation

@christianlupus
Copy link
Collaborator

Topic and Scope

The title prop of the NcAppNavigationItem is deprecated and should be replaced by the name prop. This PR will do so.

Concerns/issues

None known.

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

Signed-off-by: Christian Wolf <[email protected]>
@christianlupus christianlupus added the Frontend Issue or PR related to the frontend code label Nov 15, 2023
@christianlupus christianlupus added this to the Release 0.10.3 milestone Nov 15, 2023
Signed-off-by: Christian Wolf <[email protected]>
@codecov
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #1893 (a92300f) into master (0ff8bcc) will not change coverage.
Report is 4 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1893   +/-   ##
=======================================
  Coverage   79.55%   79.55%           
=======================================
  Files          89       89           
  Lines        2582     2582           
=======================================
  Hits         2054     2054           
  Misses        528      528           
Flag Coverage Δ
integration 21.99% <ø> (ø)
migration 5.84% <ø> (ø)
unittests 55.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

Test Results

     27 files  1 242 suites   5m 32s ⏱️
   510 tests    510 ✔️ 0 💤 0
4 590 runs  4 589 ✔️ 1 💤 0

Results for commit a92300f.

Copy link
Collaborator

@seyfeb seyfeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seyfeb seyfeb merged commit bf7996e into master Nov 19, 2023
@seyfeb seyfeb deleted the maintenance/navigation-item-title branch November 19, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Frontend Issue or PR related to the frontend code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants