Use of external package for triggering the file dialogs #1832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1832 +/- ##
=======================================
Coverage 79.48% 79.48%
=======================================
Files 87 87
Lines 2559 2559
=======================================
Hits 2034 2034
Misses 525 525
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Collaborator
Author
|
/approve |
nextcloud-cookbook-bot
approved these changes
Oct 9, 2023
Collaborator
nextcloud-cookbook-bot
left a comment
nextcloud-cookbook-bot
left a comment
There was a problem hiding this comment.
Automatically approved by GitHub action on behalf of /approve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file dialogs shold no longer be accessed by means of
OCin JS. This PR will use the suggested method of using the @ nextcloud/dialogs package.