Skip to content

Conversation

@SethFalco
Copy link
Contributor

Topic and Scope

When renaming a recipe, if the recipe name is already taken it throws it shows a modal with Unknown answer returned from server. See logs..

This should be handled the same way as creating a new recipe, using the dedicated error returned from RecipeExistsException.

image

Concerns/issues

N/A

Chores

On the side, I've also updated the command to run nextcloud-docker-dev. It now specifies the nextcloud service, as this what is the recommendation from their repository.

docker-compose up -d nextcloud

https://github.com/juliushaertl/nextcloud-docker-dev/blob/master/bootstrap.sh#L124

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

@SethFalco SethFalco force-pushed the fix/conflicting-name-on-update branch from 897e198 to 2b66aea Compare July 30, 2023 16:37
@christianlupus christianlupus force-pushed the fix/conflicting-name-on-update branch from 2b66aea to 31db708 Compare August 31, 2023 08:44
Signed-off-by: Christian Wolf <[email protected]>
@christianlupus christianlupus merged commit c73d3f7 into nextcloud:master Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants