Skip to content

Conversation

@christianlupus
Copy link
Collaborator

Topic and Scope

This should simply fix the build process in development mode.

Additionally, all NPM dependencies have been updated recursively.

Concerns/issues

The stylelint-order is pinned, see ream88/stylelint-config-idiomatic-order#78. This should be reverted to the default behavior once fixed upstream.

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
@christianlupus
Copy link
Collaborator Author

/approve

Copy link
Collaborator

@nextcloud-cookbook-bot nextcloud-cookbook-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by GitHub action on behalf of /approve

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #1758 (99407bd) into master (f52efd0) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1758   +/-   ##
=======================================
  Coverage   79.42%   79.42%           
=======================================
  Files          87       87           
  Lines        2552     2552           
=======================================
  Hits         2027     2027           
  Misses        525      525           
Flag Coverage Δ
integration 21.27% <ø> (ø)
migration 5.91% <ø> (ø)
unittests 56.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@christianlupus christianlupus merged commit 0f2f891 into master Jul 17, 2023
@christianlupus christianlupus deleted the fix/build-without-prettier branch July 17, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants