Skip to content

Enhance recipe recalculation algorithm #1723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
christianlupus merged 7 commits into from
Jun 30, 2023
Merged

Enhance recipe recalculation algorithm #1723

christianlupus merged 7 commits into from
Jun 30, 2023
+113 −48

Conversation

@j0hannesr0th
Copy link
Contributor

@j0hannesr0th j0hannesr0th commented Jun 11, 2023 •
edited by christianlupus
Loading

Topic and Scope

Fixes at least partially #1603

See it live:

Screencast.from.11.06.2023.23.44.37.webm

Concerns/issues

None

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

@j0hannesr0th j0hannesr0th mentioned this pull request Jun 11, 2023
Closed
6 tasks
@github-actions
Copy link

github-actions bot commented Jun 11, 2023 •
edited
Loading

Test Results

     27 files  1 233 suites   6m 45s ⏱️
   498 tests    498 ✔️ 0 💤 0 ❌
4 482 runs  4 481 ✔️ 1 💤 0 ❌

Results for commit 45166e0.

♻️ This comment has been updated with latest results.

@j0hannesr0th j0hannesr0th mentioned this pull request Jun 13, 2023
Open
christianlupus
christianlupus approved these changes Jun 30, 2023
View reviewed changes
Copy link
Collaborator

@christianlupus christianlupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some flaws still in the code but this is yet much better than before.

I unlinked the underlying issue as it is not yet fully satisfied.

@christianlupus christianlupus enabled auto-merge June 30, 2023 17:49
@christianlupus christianlupus merged commit 838080d into nextcloud:master Jun 30, 2023
@christianlupus christianlupus added this to the Release 0.10.3 milestone Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christianlupus christianlupus christianlupus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Release 0.10.3

Development

Successfully merging this pull request may close these issues.

2 participants

@j0hannesr0th @christianlupus