make server api compliant fixes #1464

[Leptopoda]

Fixes #1464

Signed-off-by: Nikolas Rimikis [email protected]

[github-actions]

Test Results

     21 files     959 suites   5m 22s ⏱️
   498 tests    498 ✔️ 0 💤 0 ❌
3 486 runs  3 485 ✔️ 1 💤 0 ❌

Results for commit 1fd2668.

♻️ This comment has been updated with latest results.

[christianlupus]

There are a few issues with this PR:

1. You should create an individual filter. See here and an example.
2. No tests are provided. See above to simplify this.
3. The behavior of the API is changing. This must be reflected in the API version.
4. A corresponding entry to the changelog would be needed.
5. Once, the PR is ready, the devs need to be warned about the upcoming change in the API.

[christianlupus]

PS: Have you checked this is not causing trouble with the Vue frontend? I have not checked the branch version.

[Leptopoda]

Sounds resonable :)

I'll look into the filter stuff but can't promise my php is good enough for that.
I know this was just a dirty fix and I simply made it so I can start using and testing my generated code.

EDIT:

PS: Have you checked this is not causing trouble with the Vue frontend? I have not checked the branch version.

I haven't seen any problems but I haven't thoroughly tested it either.

[christianlupus]

You can also close this PR or tell me. I would then create/update a new PR with an appropriate filtering method.

[Leptopoda]

If I had the time I would accept the challenge but it's probably better If you do it.

I think you should be able to push to this PR? Or just close it if you want.

[christianlupus]

I will try to fix it and push to the repository. I have not tried it yet.