Skip to content

Conversation

@christianlupus
Copy link
Collaborator

Closes #1428

@christianlupus christianlupus marked this pull request as ready for review January 15, 2023 10:57
@codecov
Copy link

codecov bot commented Jan 15, 2023

Codecov Report

Merging #1446 (f909fd1) into master (12aa7dc) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1446   +/-   ##
=======================================
  Coverage   78.85%   78.85%           
=======================================
  Files          86       86           
  Lines        2303     2303           
=======================================
  Hits         1816     1816           
  Misses        487      487           
Flag Coverage Δ
integration 21.53% <ø> (ø)
migration 4.21% <ø> (ø)
unittests 57.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

Test Results

     21 files     952 suites   4m 57s ⏱️
   495 tests    495 ✔️ 0 💤 0
3 465 runs  3 464 ✔️ 1 💤 0

Results for commit f909fd1.

@MarcelRobitaille
Copy link
Collaborator

I just check this out and it seems to be working for me too. I have arrows for the ingredients list. The code looks good. In general, I prefer this <TriangleDownIcon /> over "magic" classnames. LGTM

@christianlupus christianlupus merged commit ec56a67 into master Jan 15, 2023
@christianlupus christianlupus deleted the fix/1428-missing-icons branch January 15, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Up/downarrow Icons missing in EditInputGroup

3 participants