Make info block visibility configurable #1404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
Peek.2022-12-29.15-59.mp4 |
christianlupus
requested changes
Jan 14, 2023
Collaborator
christianlupus
left a comment
christianlupus
left a comment
There was a problem hiding this comment.
Some minor changes are still required. Then, it can be merged.
| 'folder' => $folder, | ||
| 'update_interval' => $interval, | ||
| 'print_image' => $printImage, | ||
| 'visibleInfoBlocks' => array(), |
Collaborator
There was a problem hiding this comment.
This is not sufficient to test it on PHP level. Please add a few test cases in the data provider at line 147.
Signed-off-by: Christian Wolf <git@christianwolf.email>
Signed-off-by: Marcel Robitaille <mail@marcelrobitaille.me>
And connect to UI elements Signed-off-by: Marcel Robitaille <mail@marcelrobitaille.me>
Signed-off-by: Marcel Robitaille <mail@marcelrobitaille.me>
Only refresh the config from the database in a single action in the store Don't update the config in two different places in the settings dialog Signed-off-by: Marcel Robitaille <mail@marcelrobitaille.me>
Signed-off-by: Marcel Robitaille <mail@marcelrobitaille.me>
Signed-off-by: Marcel Robitaille <mail@marcelrobitaille.me>
Signed-off-by: Marcel Robitaille <mail@marcelrobitaille.me>
Signed-off-by: Marcel Robitaille <mail@marcelrobitaille.me>
Signed-off-by: Marcel Robitaille <mail@marcelrobitaille.me>
Signed-off-by: Marcel Robitaille <mail@marcelrobitaille.me>
Signed-off-by: Christian Wolf <git@christianwolf.email>
Signed-off-by: Christian Wolf <git@christianwolf.email>
christianlupus
force-pushed
the
906-hide-info-blocks
branch
from
e5e6efb to
2684d21
Compare
Signed-off-by: Christian Wolf <git@christianwolf.email>
christianlupus
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #906