Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pull-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ jobs:

if [ $(git diff --name-only package.json | wc -l) -gt 0 ]; then
echo '::error file=package.json::The package.json file is not validly formatted.'
echo '::notice::It is suggested to run `npm run package/lint`.'
echo '::notice::It is suggested to run `npm run package-lint` and commit locally.'
exit 1
fi

Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@
- Allow for PlantUML diagrams in documentation
[#1229](https://github.com/nextcloud/cookbook/pull/1229) @christianlupus
- Remove deprecated `::v-deep` CSS syntax @christianlupus
- Disable webpack bundle analyzer plugin by default to speed up development cycle
[#1263](https://github.com/nextcloud/cookbook/pull/1263) @MarcelRobitaille

### Documentation
- Fix bad writing
Expand Down
2 changes: 1 addition & 1 deletion docs/dev/frontend/webpack-bundle-analyzer.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ The Webpack Bundle Analyzer Plugin is installed as a development dependency (see

## Usage

The interactive view of the treemap is available at `http://localhost:8888` while running `npm run dev` in the terminal.
The interactive view of the treemap is available at `http://localhost:8888` while running `npm run build-bundle-analyzer` in the terminal.

![Bundle Analyzer example](assets/webpack-bundle-analyzer_example.png)

Expand Down
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"main": "src/main.js",
"scripts": {
"build": "npx webpack --node-env production --progress --config webpack.config.js",
"build-dev": "npx webpack --node-env development --progress --config webpack.config.js",
"build-bundle-analyzer": "npx webpack --node-env development --progress --config webpack.devel.js --env BUNDLE_ANALYZER=true",
"build-dev": "npx webpack --node-env development --progress --config webpack.devel.js",
"dev": "npx webpack --node-env development --progress --watch --config webpack.devel.js",
"eslint": "npx eslint --cache --cache-strategy content 'src/**/*.{vue,js}'",
"eslint-fix": "npx eslint --cache --cache-strategy content --fix 'src/**/*.{vue,js}'",
Expand Down
6 changes: 3 additions & 3 deletions webpack.devel.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ const base = require('./webpack.config.js')
const BundleAnalyzerPlugin = require('webpack-bundle-analyzer').BundleAnalyzerPlugin

module.exports = (env) => merge(base(env), {
plugins: [
plugins: env.BUNDLE_ANALYZER ? [
new BundleAnalyzerPlugin(
{
openAnalyzer: false,
openAnalyzer: true,
}
)
],
] : [],
})