Skip to content

Creation of integration tests #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christianlupus merged 9 commits into from
Sep 7, 2022
Merged

Creation of integration tests #1195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2025975
Install test heleper package
christianlupus Sep 7, 2022
b16fb7c
Enabling autoloading of helper classes during testing
christianlupus Sep 7, 2022
5e33007
Create abstract test class for integration testing
christianlupus Sep 7, 2022
05c2856
Create basic structure to run tests against the database
christianlupus Sep 7, 2022
adf093b
Fix some minor issues in the current implementation
christianlupus Sep 7, 2022
3b7b3f7
Fix PostgreSQL errors
christianlupus Sep 7, 2022
07052e1
Make sqlite test run successfully
christianlupus Sep 7, 2022
db437b2
Removed Polyfilling as the old versions of the server core
christianlupus Sep 7, 2022
ab82242
Update changelog
christianlupus Sep 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/deploy/appinfo/info.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<screenshot>https://raw.githubusercontent.com/nextcloud/cookbook/stable/img/screenshot2.png</screenshot>
<dependencies>
<php min-version="7.4"/>
<nextcloud min-version="19" max-version="24"/>
<nextcloud min-version="21" max-version="24"/>
</dependencies>
<navigations>
<navigation>
Expand Down
26 changes: 0 additions & 26 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,27 +130,7 @@ jobs:
phpVersion: "8.1"
httpServer: "apache"

# Test different core versions additionally with lower PHP versions
- database: mysql
coreVersion: stable19
phpVersion: "7.4"
httpServer: "apache"
- database: mysql
coreVersion: stable20
phpVersion: "7.4"
httpServer: "apache"

# Test different PHP versions additionally
# - database: mysql
# # stable24 branch needs PHP 7.4
# coreVersion: stable23
# phpVersion: "7.3"
# httpServer: "apache"
# - database: mysql
# coreVersion: stable24
# # We have already PHP 7.4 with stable 19/20
# phpVersion: "7.4"
# httpServer: "apache"
- database: mysql
coreVersion: stable24
phpVersion: "8.1"
Expand All @@ -161,12 +141,6 @@ jobs:
coreVersion: stable24
phpVersion: "8.1"
httpServer: "nginx"

# Test against master (optionally)
# - database: mysql
# coreVersion: master
# phpVersion: "8.1"
# httpServer: "apache"

steps:
- name: Checkout the app
Expand Down
16 changes: 16 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,33 @@
## [Unreleased]

### Added
- Create structure to run integration tests against a real database
[#1195](https://github.com/nextcloud/cookbook/pull/1195) @christianlupus

### Changed
- Migrate ILogger to LoggerInterface
[#1192](https://github.com/nextcloud/cookbook/pull/1192) @miles170

### Fixed
- Close security issue by enabling CSRF protection on most endpoints
[#1190](https://github.com/nextcloud/cookbook/pull/1190) @christianlupus
- Fix bug in DB access class to prevent PostgreSQL from viewing all recipes of a category
[#1195](https://github.com/nextcloud/cookbook/pull/1195) @christianlupus
- Fix minor bug to make API access consistent with API definitions and internal structure more well-defined
[#1195](https://github.com/nextcloud/cookbook/pull/1195) @christianlupus

### Documentation
- Defining new API interface to fix security issue
[#1186](https://github.com/nextcloud/cookbook/pull/1186) @christianlupus

### Deprecated
- Deprecate NC core version V21
[#1195](https://github.com/nextcloud/cookbook/pull/1195) @christianlupus

### Removed
- Removed support for NC core <= V20
[#1195](https://github.com/nextcloud/cookbook/pull/1195) @christianlupus


## 0.9.14 - 2022-08-29

Expand Down
2 changes: 1 addition & 1 deletion appinfo/info.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<screenshot>https://raw.githubusercontent.com/nextcloud/cookbook/stable/img/screenshot2.png</screenshot>
<dependencies>
<php min-version="7.4"/>
<nextcloud min-version="19" max-version="24"/>
<nextcloud min-version="21" max-version="24"/>
</dependencies>
<navigations>
<navigation>
Expand Down
8 changes: 7 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
"ext-libxml": "*"
},
"require-dev": {
"nextcloud/coding-standard": "^1.0.0"
"nextcloud/coding-standard": "^1.0.0",
"christophwurst/nextcloud_testing": "^0.12.4"
},
"scripts": {
"cs:check": "./vendor/bin/php-cs-fixer fix --dry-run --diff",
Expand All @@ -23,5 +24,10 @@
"platform": {
"php": "7.4"
}
},
"autoload-dev": {
"psr-4": {
"OCA\\Cookbook\\tests\\": "tests/"
}
}
}
Loading