Skip to content

Fix keyword ordering buttons clipped by top bar #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christianlupus merged 3 commits into from
Jul 24, 2022
Merged

Fix keyword ordering buttons clipped by top bar #1103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3740765
Fix keyword ordering buttons clipped by top bar
MarcelRobitaille Jul 23, 2022
6d96626
Update changelog
MarcelRobitaille Jul 23, 2022
bd7f506
Run prettier
MarcelRobitaille Jul 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
### Fixed
- Prevent slow loading of recipes due to iteration over all files
[#1072](https://github.com/nextcloud/cookbook/pull/1072) @christianlupus
- Fix keyword ordering buttons being clipped by top bar
[#1103](https://github.com/nextcloud/cookbook/pull/1103) @MarcelRobitaille

### Maintenance
- Add composer.json to version control to have unique installed dependency versions
Expand Down
14 changes: 8 additions & 6 deletions src/components/RecipeListKeywordCloud.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,16 @@
/>
</transition-group>
</div>
<div class="settings-buttons">
<div v-if="uniqKeywords.length > 0" class="settings-buttons">
<button
class="ordering-button"
class="settings-button ordering-button"
:title="orderButtonTitle"
@click="toggleOrderCriterium"
>
{{ orderButtonText }}
</button>
<button
class="settings-button"
:class="toggleSizeIcon"
:title="t('cookbook', 'Toggle keyword area size')"
@click="toggleCloudSize"
Expand Down Expand Up @@ -222,6 +223,7 @@ export default {
<style lang="scss" scoped>
.kw-container {
position: relative;
display: flex;
}

.kw {
Expand Down Expand Up @@ -249,11 +251,11 @@ export default {
}

.settings-buttons {
position: absolute;
right: 10px;
bottom: -8px;
display: flex;
align-items: flex-start;
padding: 0.5rem;

button {
.settings-button {
min-height: 8px;
font-size: 8px;
vertical-align: bottom;
Expand Down