Skip to content

Conversation

@christianlupus
Copy link
Collaborator

Closes #1068

@github-actions
Copy link

github-actions bot commented Jul 6, 2022

Unit Test Results

     36 files       36 suites   11m 40s ⏱️
   254 tests    254 ✔️ 0 💤 0
3 048 runs  3 048 ✔️ 0 💤 0

Results for commit 799b5a5.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #1072 (799b5a5) into master (27db283) will increase coverage by 0.80%.
The diff coverage is 48.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1072      +/-   ##
==========================================
+ Coverage   44.58%   45.38%   +0.80%     
==========================================
  Files          50       53       +3     
  Lines        1965     2069     +104     
==========================================
+ Hits          876      939      +63     
- Misses       1089     1130      +41     
Flag Coverage Δ
integration 2.17% <0.00%> (-0.12%) ⬇️
migration 4.49% <6.15%> (+0.16%) ⬆️
unittests 38.71% <42.30%> (+0.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/Db/DbTypesPolyfillHelper.php 0.00% <0.00%> (ø)
lib/Db/RecipeDb.php 0.00% <0.00%> (ø)
lib/Search/Provider.php 0.00% <0.00%> (ø)
lib/Service/DbCacheService.php 0.00% <0.00%> (ø)
lib/Service/RecipeService.php 0.00% <0.00%> (ø)
lib/Helper/Filter/DB/RecipeDatesFilter.php 100.00% <100.00%> (ø)
lib/Helper/Filter/NormalizeRecipeFileFilter.php 100.00% <100.00%> (ø)
lib/Migration/Version000000Date20220703174647.php 100.00% <100.00%> (ø)

@christianlupus christianlupus merged commit aa1ebe8 into master Jul 6, 2022
@christianlupus christianlupus deleted the fix/1068-add-dates-to-db branch July 6, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

All relevant data of the recipes should be cached in DB

2 participants