Skip to content

Conversation

@christianlupus
Copy link
Collaborator

Closes #979

@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #1055 (58ff14f) into master (4e5d528) will decrease coverage by 1.01%.
The diff coverage is 17.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1055      +/-   ##
==========================================
- Coverage   42.11%   41.09%   -1.02%     
==========================================
  Files          44       46       +2     
  Lines        1876     1925      +49     
==========================================
+ Hits          790      791       +1     
- Misses       1086     1134      +48     
Flag Coverage Δ
migration 4.41% <0.00%> (-0.12%) ⬇️
unittests 36.67% <17.85%> (-0.91%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/Db/RecipeDb.php 0.00% <0.00%> (ø)
lib/Exception/NoDownloadWasCarriedOutException.php 0.00% <0.00%> (ø)
lib/Helper/DownloadHelper.php 0.00% <0.00%> (ø)
lib/Service/HtmlDownloadService.php 100.00% <100.00%> (ø)
lib/Exception/ImportException.php 0.00% <0.00%> (-100.00%) ⬇️

@github-actions
Copy link

Unit Test Results

     24 files       24 suites   8m 38s ⏱️
   202 tests    202 ✔️ 0 💤 0
2 424 runs  2 424 ✔️ 0 💤 0

Results for commit ca7f322.

Signed-off-by: Christian Wolf <[email protected]>
@christianlupus christianlupus merged commit 1ca8900 into master Jun 23, 2022
@christianlupus christianlupus deleted the fix/979-curl-downloader branch June 23, 2022 19:29
christianlupus added a commit that referenced this pull request Jun 24, 2022
Fix for #1055

Signed-off-by: Christian Wolf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider using cURL instead of file_get_contents for recipe import

2 participants