Skip to content

Conversation

@TheMBeat
Copy link
Contributor

This should fix #1042

@github-actions
Copy link

github-actions bot commented Jun 15, 2022

Unit Test Results

     22 files       22 suites   7m 22s ⏱️
   192 tests    192 ✔️ 0 💤 0
2 112 runs  2 112 ✔️ 0 💤 0

Results for commit f83400f.

♻️ This comment has been updated with latest results.

@christianlupus
Copy link
Collaborator

This implementation has the problem that it is only part of the solution for the issue. It hides the count iff the value is not present.

Two more things need to be addressed:

  • there is no way as far as I see it to remove the actual value (or set it to null). So, we need another GUI extension.
  • the PHP backend will set the value back to one of it is not valid or not present as far as I know. This needs fixing. Especially, since the regular check will fix it on regular intervals.

The falling code checks need also fixing. One of them is a big i introduced and will fix that. The other (DCO) needs requiring the gut history. This was introduced by the GitHub website: when you mehr the upstream branch via the web site, these commit are neither signed (optionally) not signed off (mandatory).

@TheMBeat
Copy link
Contributor Author

How about if we take a specific number (e.g. 999) as an indicator for hiding?
Could be connected with a checkbox that changes the value.

About the DCO error I still carey.

@christianlupus
Copy link
Collaborator

christianlupus commented Jun 15, 2022

Why introducing a magic number of this is not necessary? There is the literal null ready to be used both in PHP and in JavaScript/JSON. That would fit perfectly, I think. Don't you agree?

@christianlupus
Copy link
Collaborator

The problem with the failing check should be fixed by now. As soon as you put new commits on the PR, the red mark should be gone.

What are your plans to continue from here on, @TheMBeat? Regarding the PHP part, I can help but the UI/UX/GUI is not necessarily my favorite. Thus, please tell us your intended next steps. Thank you!

@TheMBeat TheMBeat closed this Jul 5, 2022
@christianlupus
Copy link
Collaborator

@TheMBeat did you close this issue die to its complexity or because you had issues with the falling actions?

@TheMBeat
Copy link
Contributor Author

TheMBeat commented Jul 8, 2022

I closed it because of the failing actions and want to start a new attempt on a clean code base.

@TheMBeat TheMBeat deleted the HideRecipeYield branch July 15, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make recipeYield optional

2 participants