-
Notifications
You must be signed in to change notification settings - Fork 102
Hide recipe yield #1044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide recipe yield #1044
Conversation
Merge from Master
Update from Master
Signed-off-by: TheMBeat <[email protected]>
|
This implementation has the problem that it is only part of the solution for the issue. It hides the count iff the value is not present. Two more things need to be addressed:
The falling code checks need also fixing. One of them is a big i introduced and will fix that. The other (DCO) needs requiring the gut history. This was introduced by the GitHub website: when you mehr the upstream branch via the web site, these commit are neither signed (optionally) not signed off (mandatory). |
|
How about if we take a specific number (e.g. 999) as an indicator for hiding? About the DCO error I still carey. |
|
Why introducing a magic number of this is not necessary? There is the literal |
|
The problem with the failing check should be fixed by now. As soon as you put new commits on the PR, the red mark should be gone. What are your plans to continue from here on, @TheMBeat? Regarding the PHP part, I can help but the UI/UX/GUI is not necessarily my favorite. Thus, please tell us your intended next steps. Thank you! |
Signed-off-by: TheMBeat <[email protected]>
…ud-cookbook into HideRecipeYield Signed-off-by: TheMBeat <[email protected]>
|
@TheMBeat did you close this issue die to its complexity or because you had issues with the falling actions? |
|
I closed it because of the failing actions and want to start a new attempt on a clean code base. |
This should fix #1042