Skip to content

Quick fix to prevent long name of recipes #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christianlupus merged 3 commits into from
May 21, 2022
Merged

Quick fix to prevent long name of recipes #1014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7da7c23
Quick fix to prevent long name of recipes
christianlupus May 21, 2022
5537c95
Update changelog
christianlupus May 21, 2022
4e9eabe
Merge remote-tracking branch 'upstream/master' into fix/177-too-long-…
christianlupus May 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
[#1000](https://github.com/nextcloud/cookbook/pull/1000) @seyfeb
- Reenable the fixup action after deprecation in central repository
[#1012](https://github.com/nextcloud/cookbook/pull/1012) @christianlupus
- Trim recipe name to a maximum length to fit in the database
[#1014](https://github.com/nextcloud/cookbook/pull/1014) @christianlupus
- Update eslint-plugin-vue

### Documentation
Expand Down
5 changes: 5 additions & 0 deletions lib/Service/RecipeService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,11 @@ public function checkRecipe(array $json): array {
// Make sure that "name" doesn't have any funky characters in it
$json['name'] = $this->cleanUpString($json['name'], false, true);

// Restrict the length of the name to be not longer than what the DB can store
if (strlen($json['name']) > 256) {
$json['name'] = substr($json['name'], 0, 256);
}

// Make sure that "image" is a string of the highest resolution image available
if (isset($json['image']) && $json['image']) {
if (is_array($json['image'])) {
Expand Down