Sabre dav 3.2 requires on each vcard to have fn set #8
Conversation
|
Anyone 🏜 @nextcloud/contacts |
| @@ -93,6 +93,9 @@ angular.module('contactsApp') | |||
| newContact.uid(newUid); | |||
| newContact.setUrl(addressBook, newUid); | |||
| newContact.addressBookId = addressBook.displayName; | |||
| if (_.isUndefined(newContact.fullName()) || newContact.fullName() === '') { | |||
| newContact.fullName(t('contacts', 'New Contact')); | |||
There was a problem hiding this comment.
This should be capitalized like »New contact« – we always only capitalize the first word. ;)
There was a problem hiding this comment.
So it should be NewContact.fullName everywhere 🤔 ... this would also affect lines which are not touched by this PR - so I think I am misunderstanding you @jancborchardt
There was a problem hiding this comment.
@MariusBluem I mean the text:
fullName(t('contacts', 'New Contact'));
should be
fullName(t('contacts', 'New contact'));
(lowercase c)
|
@MariusBluem everything else seems okay. Can you add @jancborchardt changes so we can merge it. :) |
|
What about the change in the contact_model 😁 https://github.com/owncloud/contacts/pull/526/files |
MariusBluem
added
2. developing
* Sabre dav 3.2 requires on each vcard to have fn set * Force to set fn before sending back the vcard to the server * New Contact -> New contact
rullzer
force-pushed
the
downstream-sabre-fn
branch
from
db8cda2 to
ed1659d
Compare
|
This fixes #29 LGTM |
skjnldsv
added
4. to release
Downstream from owncloud/contacts#526
cc @irgendwie @Henni