Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix escaping issue on title #73

Merged
merged 1 commit into from
Dec 29, 2016
Merged

Fix escaping issue on title #73

merged 1 commit into from
Dec 29, 2016

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Dec 28, 2016 •
edited
Loading

Signed-off-by: John Molakvoæ (skjnldsv) [email protected]

For quick testing: contacts.tar.gz

@skjnldsv
Fix #53
ae6925c 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv added 3. to review Waiting for reviews bug Something isn't working labels Dec 28, 2016
This was referenced Dec 28, 2016
Closed
Closed
@skjnldsv skjnldsv force-pushed the fix-escaping-error-on-displayName branch from 6213471 to ae6925c Compare December 29, 2016 09:38
@skjnldsv skjnldsv self-assigned this Dec 29, 2016
@skjnldsv
Copy link
Member Author

skjnldsv commented Dec 29, 2016 •
edited
Loading

@raidev and @itswg approved in #53.
Can I have one more approval from a fellow nextcloud coworker? :D

@skjnldsv skjnldsv added this to the 1.5.3 milestone Dec 29, 2016
@Henni
Copy link
Member

Henni commented Dec 29, 2016

👍

@skjnldsv skjnldsv requested a review from Henni December 29, 2016 19:02
Henni
Henni approved these changes Dec 29, 2016
View reviewed changes
Copy link
Member

@Henni Henni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@skjnldsv skjnldsv merged commit f309052 into master Dec 29, 2016
@skjnldsv skjnldsv deleted the fix-escaping-error-on-displayName branch December 29, 2016 19:03
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 4. to release Ready to be released and/or waiting for tests to finish 3. to review Waiting for reviews labels Feb 7, 2017
@frankmayer frankmayer mentioned this pull request Feb 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Henni Henni Henni approved these changes

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@irgendwie irgendwie Awaiting requested review from irgendwie

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working
Projects
None yet
Milestone
1.5.3
Development

Successfully merging this pull request may close these issues.
2 participants
@skjnldsv @Henni