Skip to content

Contacts 3.0.0 #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 360 commits into from
Sep 28, 2018
Merged

Contacts 3.0.0 #596

merged 360 commits into from
Sep 28, 2018

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Aug 16, 2018

This is a big update of our app and a refactor of the data structure to ensure:

  • Better maintainability ⛑️
  • Lower level entry 👩‍🎓 👨‍🎓
  • Performance boost 🚀

List of fixes

@skjnldsv skjnldsv added enhancement New feature or request 2. developing Work in progress design Related to the design compatibility Compatibility with other services high High priority papercut Annoying recurring issue with possibly simple fix. labels Aug 16, 2018
@skjnldsv skjnldsv added this to the 3.0.0 milestone Aug 16, 2018
Jessica and others added 19 commits August 28, 2018 15:39
…r there is still some error in the code that does not effectively implement the filter function. Added debounce package and function.
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@splitt3r
Copy link

splitt3r commented Aug 29, 2018

A bit off topic but the copyright headers miss an @ sign. For example:

* author Team Popcorn <[email protected]>

https://github.com/nextcloud/contacts/blob/vue/css/settings-section.scss#L5

I think @sleepypioneer is the right person to fix it?

@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 28, 2018
Delete the contacts from the store after an ab deletion
@nextcloud-bot nextcloud-bot mentioned this pull request Sep 28, 2018
7 tasks
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment