Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show error on empty group name #4322

Merged
merged 1 commit into from
Feb 3, 2025
Merged

fix: show error on empty group name #4322

merged 1 commit into from
Feb 3, 2025

Conversation

hamza221
Copy link
Contributor

No description provided.

@hamza221 hamza221 added bug Something isn't working 3. to review Waiting for reviews labels Jan 31, 2025
@hamza221 hamza221 self-assigned this Jan 31, 2025
@hamza221 hamza221 requested a review from GVodyanov as a code owner January 31, 2025 07:12
@hamza221
Copy link
Contributor Author

/backport to stable7.0

@hamza221
Copy link
Contributor Author

/backport to stable6.1

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 11.12%. Comparing base (b028792) to head (92aa49c).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/components/AppNavigation/RootNavigation.vue 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4322      +/-   ##
============================================
- Coverage     11.13%   11.12%   -0.01%     
  Complexity      265      265              
============================================
  Files           121      121              
  Lines          5542     5545       +3     
  Branches       1200     1201       +1     
============================================
  Hits            617      617              
- Misses         4803     4806       +3     
  Partials        122      122              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamza221
Copy link
Contributor Author

/backport to stable6.0

@hamza221
Copy link
Contributor Author

/backport to stable6.1

Copy link
Contributor

@GVodyanov GVodyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hamza221 hamza221 merged commit 95fbd63 into main Feb 3, 2025
37 of 39 checks passed
@hamza221 hamza221 deleted the fix/empty-group-name branch February 3, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants