-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh(sharing): Rename delete
to unshare from me
for shared address books
#3837
enh(sharing): Rename delete
to unshare from me
for shared address books
#3837
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3837 +/- ##
==========================================
- Coverage 2.45% 2.09% -0.37%
- Complexity 0 261 +261
==========================================
Files 89 114 +25
Lines 4519 5299 +780
Branches 1155 1163 +8
==========================================
Hits 111 111
- Misses 4288 5068 +780
Partials 120 120 ☔ View full report in Codecov by Sentry. |
Created a principals.js store (in Pinia instead of Vuex), and implemented it where needed. @miaulalala Could you please make sure that the structure of the PS for future reference seeing as dealing with this was a bit of a blocker, apparently when having to use stores in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good
Signed-off-by: Anna Larch <[email protected]>
7daa499
to
5d730e1
Compare
Close nextcloud/server#1653