Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(sharing): Rename delete to unshare from me for shared address books #3837

Merged

Conversation

miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Mar 5, 2024

@miaulalala miaulalala added the 3. to review Waiting for reviews label Mar 5, 2024
@miaulalala miaulalala self-assigned this Mar 5, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 2.09%. Comparing base (bf205cc) to head (7daa499).

❗ Current head 7daa499 differs from pull request most recent head 5d730e1. Consider uploading reports for the commit 5d730e1 to get more accurate results

Files Patch % Lines
...nts/AppNavigation/Settings/SettingsAddressbook.vue 0.00% 9 Missing ⚠️
src/store/principals.js 0.00% 3 Missing ⚠️
src/main.js 0.00% 2 Missing ⚠️
src/views/Contacts.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              main   #3837      +/-   ##
==========================================
- Coverage     2.45%   2.09%   -0.37%     
- Complexity       0     261     +261     
==========================================
  Files           89     114      +25     
  Lines         4519    5299     +780     
  Branches      1155    1163       +8     
==========================================
  Hits           111     111              
- Misses        4288    5068     +780     
  Partials       120     120              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristophWurst ChristophWurst marked this pull request as draft March 13, 2024 12:10
@ChristophWurst ChristophWurst added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Mar 13, 2024
@GVodyanov
Copy link
Contributor

Created a principals.js store (in Pinia instead of Vuex), and implemented it where needed. @miaulalala Could you please make sure that the structure of the principalUrl in SettingsAddressbook.vue is indeed as you want it to be in order for the v-if to work?

PS for future reference seeing as dealing with this was a bit of a blocker, apparently when having to use stores in beforeMount, don't use mapStores seeing as it isn't initialized at that time, and the store is undefined. Caused me a bit of troubles 😅

@miaulalala miaulalala marked this pull request as ready for review March 28, 2024 10:14
@miaulalala miaulalala added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 28, 2024
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@miaulalala miaulalala force-pushed the enh/rename-delete-to-unshare-for-shared-addressbooks branch from 7daa499 to 5d730e1 Compare April 3, 2024 10:12
@miaulalala miaulalala enabled auto-merge April 3, 2024 10:14
@miaulalala miaulalala merged commit 7e0b7b4 into main Apr 3, 2024
20 checks passed
@miaulalala miaulalala deleted the enh/rename-delete-to-unshare-for-shared-addressbooks branch April 3, 2024 10:16
@st3iny st3iny added this to the v6.1.0 milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
Development

Successfully merging this pull request may close these issues.

Can not delete group shared calendars (and addressbooks I guess)
4 participants