Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address book data lost when any user receiving a share is deleted #64

Closed
cemrich opened this issue Dec 19, 2016 · 7 comments
Closed

Address book data lost when any user receiving a share is deleted #64

cemrich opened this issue Dec 19, 2016 · 7 comments
Labels
bug Something isn't working high High priority invalid This doesn't seem right

Comments

@cemrich
Copy link

cemrich commented Dec 19, 2016

Steps to reproduce

  1. Create user1 with an address book shared to group1
  2. Create user2 of group1 to view the address book
  3. Delete user2

Expected behaviour

User2 gets deleted but the shared address book of user1 remains intact.

Actual behaviour

The shared address book of user1 gets deleted. The tables oc_addressbooks and oc_cards are wiped of all information regarding this address book. If the given address book is the only one of user1, the "infinite loading bug" as described in #58 appears.

Server configuration

Operating system: ?

Web server: ?

Database: mysql 5.1.73

PHP version: 7.0.13

Nextcloud version: 11.0.0 (stable)

Contacts version: 1.5.2

Updated from an older Nextcloud or fresh install: fresh install

Signing status:

No errors have been found.

Are you using an external user-backend, if yes which one: no

Client configuration

Browser: Firefox 50.0.2 and Chrome 54.0.2840.99 m (64-bit)

Operating system: Windows 10

@jeweloper
Copy link

I can confirm this bug.
In my case I shared the address book of user1 directly to user2.
After I deleted user2, I sadly missed the address book of user1. 😩

To restore the address book:
Is it enough to restore the corresponding records in oc_addressbooks, oc_cards and oc_cards_properties?
This is exactly what I done by now and at first sight everything seems to be OK.
Or did I possibly miss something to restore a specific book from a database dump.

Thx for your help.

@nickallevato
Copy link

@jeweloper thank you for this post! Saved our butts because:

  1. Same bug (deleted user and lost all contacts).
  2. I was restoring just _cards & _cards_properties and no contacts.

Read your post, restored address-books, and contacts were back.

Thanks again, will check back on this thread in case something develops!

@ccoenen
Copy link

ccoenen commented Feb 13, 2017

So, in other words, we have a reproducible scenario where user data is lost. And this has been open for six weeks?

@cemrich cemrich changed the title Shared address book gets deleted when deleting a user Address book data lost when any user receiving a share is deleted Feb 13, 2017
@skjnldsv
Copy link
Member

@ccoenen feel free to contribute here. It's an open-source project, everyone can help us! 😃

@ccoenen
Copy link

ccoenen commented Feb 13, 2017

I'll start by proposing the label bug and putting it on the roadmap.

Code-wise, sadly, I do not need another open source project. I limit myself to scouring issue trackers, looking for important but overlooked issues.

@skjnldsv
Copy link
Member

Sure.

@cemrich I think this is a server issue. The removal of a user and the related database entries are not done here. I'll look into it.

@cemrich
Copy link
Author

cemrich commented Feb 18, 2017

Thank you for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high High priority invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

5 participants