Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): drop PHP 7.x for incompatiblity #43

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Jan 17, 2025

Some rules that we have are incompatible with PHP 7.4 and lead to failing linters. It is fair to drop support of those version imo.

Example: trailing , on last argument in a method's parameter list.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@ChristophWurst ChristophWurst merged commit e2a9dbe into master Jan 17, 2025
2 checks passed
@ChristophWurst ChristophWurst deleted the fix/noid/platform branch January 17, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants