Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: enable types_spaces rule #18

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Jul 9, 2024

I would prefer a unified way for union types ;)

Rule:

https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/930dc93a1b90eb991d13e2766a340aa6922d4a2c/doc/rules/whitespace/types_spaces.rst

Examples:

catch(A | B) => catch(A|B)

function foo(): A | B => function foo(): A|B

Affected files in server:

   1) apps/files_versions/lib/Storage.php
   2) apps/theming/lib/Service/BackgroundService.php
   3) apps/dav/lib/BackgroundJob/OutOfOfficeEventDispatcherJob.php
   4) apps/dav/lib/BackgroundJob/UploadCleanup.php
   5) apps/dav/lib/CalDAV/WebcalCaching/RefreshWebcalService.php
   6) apps/dav/lib/CardDAV/UserAddressBooks.php
   7) apps/dav/lib/CardDAV/SystemAddressbook.php
   8) apps/settings/lib/Controller/UsersController.php
   9) apps/dav/lib/CalDAV/Schedule/IMipPlugin.php
  10) apps/files_sharing/lib/Controller/ShareAPIController.php
  11) lib/private/Avatar/AvatarManager.php

src/Config.php Outdated Show resolved Hide resolved
Rule:

https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/930dc93a1b90eb991d13e2766a340aa6922d4a2c/doc/rules/whitespace/types_spaces.rst

Examples:

`catch(A | B)` => `catch(A|B)`

`function foo(): A | B` => `function foo(): A|B`

Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb kesselb force-pushed the add-types-spaces-rule branch from 4ed2e03 to d65dcd7 Compare July 9, 2024 18:20
@juliusknorr juliusknorr merged commit d8bfac1 into master Jul 10, 2024
2 checks passed
@nickvergessen nickvergessen deleted the add-types-spaces-rule branch July 10, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants