-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
order by viewer level #1410
order by viewer level #1410
Conversation
Signed-off-by: Maxence Lange <[email protected]>
@@ -184,6 +184,7 @@ public function getCircles(?IFederatedUser $initiator, CircleProbe $probe): arra | |||
$qb->filterCircles(CoreQueryBuilder::CIRCLE, $probe); | |||
if (!is_null($initiator)) { | |||
$qb->limitToInitiator(CoreQueryBuilder::CIRCLE, $initiator); | |||
$qb->orderBy($qb->generateAlias(CoreQueryBuilder::CIRCLE, CoreQueryBuilder::INITIATOR) . '.level', 'desc'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seems to work for the front, I still have to sort https://github.com/nextcloud/contacts/blob/19f836ee23f726b919134c6642af5b8983df871e/src/components/AppNavigation/RootNavigation.vue#L351-L356
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have cache ? can you try (with the right userId) :
./occ circles:manage:list --initiator-type user --initiator
This should returns the same list than the ocs route GET /circles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/backport to stable27 |
/backport to stable26 |
@ArtificialOwl I thought that wasn't the proper fix? Why is this merged? |
@skjnldsv i could not reproduce your issue, i investigate any eventual rewriting of orderBy and could not find any reason for it to fail on your computer. Every scenario I have tested were good. Do you still have the issue ? can you share me your database; at least the table |
Ok then! 👍 |
No description provided.