Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

order by viewer level #1410

Merged
merged 1 commit into from
Oct 30, 2023
Merged

order by viewer level #1410

merged 1 commit into from
Oct 30, 2023

Conversation

ArtificialOwl
Copy link
Member

No description provided.

Signed-off-by: Maxence Lange <[email protected]>
@@ -184,6 +184,7 @@ public function getCircles(?IFederatedUser $initiator, CircleProbe $probe): arra
$qb->filterCircles(CoreQueryBuilder::CIRCLE, $probe);
if (!is_null($initiator)) {
$qb->limitToInitiator(CoreQueryBuilder::CIRCLE, $initiator);
$qb->orderBy($qb->generateAlias(CoreQueryBuilder::CIRCLE, CoreQueryBuilder::INITIATOR) . '.level', 'desc');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have cache ? can you try (with the right userId) :

./occ circles:manage:list --initiator-type user --initiator

This should returns the same list than the ocs route GET /circles

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndyScherzinger AndyScherzinger added this to the Nextcloud 28 milestone Oct 30, 2023
@ArtificialOwl ArtificialOwl merged commit 0d5813d into master Oct 30, 2023
18 checks passed
@delete-merged-branch delete-merged-branch bot deleted the enh/noid/order-by-viewer-level branch October 30, 2023 16:00
@ArtificialOwl
Copy link
Member Author

/backport to stable27

@ArtificialOwl
Copy link
Member Author

/backport to stable26

@skjnldsv
Copy link
Member

@ArtificialOwl I thought that wasn't the proper fix? Why is this merged?

@ArtificialOwl
Copy link
Member Author

@skjnldsv i could not reproduce your issue, i investigate any eventual rewriting of orderBy and could not find any reason for it to fail on your computer. Every scenario I have tested were good. Do you still have the issue ? can you share me your database; at least the table oc_circles_* ?

@skjnldsv
Copy link
Member

Every scenario I have tested were good

Ok then! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants