Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes Circles icon rendering in darkmode #1398

Merged

Conversation

privatemaker
Copy link
Contributor

Currently in the /settings/apps view when a user has dark theme enabled the Circles icon is black, when it should be white.

server-apps-circles-icon-bug

By adding attribute fill="#fff" to the SVG data this issue is resolved.

server-apps-circles-icon-fixed

The only other place I could find the icon used is in the Contacts app and this change works there as well.

circles-contacts-sidebar-icons

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@privatemaker
Copy link
Contributor Author

@ArtificialOwl maybe you want to push this simple fix through? The test suite failed on four phpunit tests which i'm 99.99% confident have nothing to do with my pull-request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants