Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close modal after creating conversation #6658

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Jan 24, 2025

fixes #6641

All rooms should be names conversation
Close modal after creating convesation
Remove leftover method

@GretaD GretaD added the 3. to review Waiting for reviews label Jan 24, 2025
@GretaD GretaD self-assigned this Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 23.00%. Comparing base (e0eb088) to head (5c937cb).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/services/talkService.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6658      +/-   ##
============================================
+ Coverage     22.97%   23.00%   +0.02%     
  Complexity      475      475              
============================================
  Files           252      252              
  Lines         12125    12112      -13     
  Branches       2302     2310       +8     
============================================
  Hits           2786     2786              
+ Misses         9012     8999      -13     
  Partials        327      327              
Flag Coverage Δ
javascript 14.53% <0.00%> (+0.01%) ⬆️
php 59.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GretaD GretaD added the bug label Jan 24, 2025
@GretaD GretaD requested a review from hamza221 January 24, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Talk conversation picker stays open after creating new conversation
2 participants