-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(talk): Only invite guest accounts to open Talk conversations #5688
Conversation
/backport to stable4.6 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5688 +/- ##
=========================================
Coverage 24.41% 24.41%
Complexity 418 418
=========================================
Files 243 243
Lines 10874 10874
Branches 1789 1790 +1
=========================================
Hits 2655 2655
Misses 8219 8219
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
It's kind of a breaking change though, right? There might be some users which were using this? |
I could first check the room status and if guests are allowed I still send these participants. Only for private rooms I ignore them. |
Done. Please test/review another time |
Works, the guests are not invited to the room if it isn't open. |
Signed-off-by: Christoph Wurst <[email protected]>
f4335bd
to
e6e8c2a
Compare
Inviting guests to a private group chat has the implication that the Talk room has to be opened up for guests. This is unexpected.
This patch adjusts the logic to only invite guest users if the Talk room is already open for guests. Otherwise they are ignored.
Fixes #5687
How to test
Repro steps from #5687
In addition, test it with an open conversation. Guests will be added.