Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(talk): Only invite guest accounts to open Talk conversations #5688

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Jan 11, 2024

Inviting guests to a private group chat has the implication that the Talk room has to be opened up for guests. This is unexpected.
This patch adjusts the logic to only invite guest users if the Talk room is already open for guests. Otherwise they are ignored.

Fixes #5687

How to test

Repro steps from #5687

In addition, test it with an open conversation. Guests will be added.

@ChristophWurst ChristophWurst added 3. to review Waiting for reviews bug labels Jan 11, 2024
@ChristophWurst ChristophWurst self-assigned this Jan 11, 2024
@ChristophWurst
Copy link
Member Author

/backport to stable4.6

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request A backport was requested for this pull request label Jan 11, 2024
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (073ed63) 24.41% compared to head (e6e8c2a) 24.41%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/services/talkService.js 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5688   +/-   ##
=========================================
  Coverage     24.41%   24.41%           
  Complexity      418      418           
=========================================
  Files           243      243           
  Lines         10874    10874           
  Branches       1789     1790    +1     
=========================================
  Hits           2655     2655           
  Misses         8219     8219           
Flag Coverage Δ
javascript 15.50% <0.00%> (ø)
php 61.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tcitworld
Copy link
Member

It's kind of a breaking change though, right? There might be some users which were using this?

@ChristophWurst
Copy link
Member Author

I could first check the room status and if guests are allowed I still send these participants. Only for private rooms I ignore them.

@ChristophWurst ChristophWurst changed the title fix(talk): Do not invite guest participants fix(talk): Only invite guest accounts to open Talk conversations Jan 18, 2024
@ChristophWurst
Copy link
Member Author

I could first check the room status and if guests are allowed I still send these participants. Only for private rooms I ignore them.

Done. Please test/review another time

@ChristophWurst ChristophWurst requested review from AndyScherzinger, nickvergessen and miaulalala and removed request for GretaD January 18, 2024 13:11
@miaulalala
Copy link
Contributor

Works, the guests are not invited to the room if it isn't open.

@ChristophWurst ChristophWurst force-pushed the fix/talk/no-guest-participants branch from f4335bd to e6e8c2a Compare January 18, 2024 14:14
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 18, 2024
@ChristophWurst ChristophWurst merged commit 31671b4 into main Jan 18, 2024
36 of 37 checks passed
@ChristophWurst ChristophWurst deleted the fix/talk/no-guest-participants branch January 18, 2024 14:19
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request A backport was requested for this pull request label Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Talk pariticipant automation implicitly enables guests if emails are invited to a room
5 participants