Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move some attachment logic to global state #5653

Merged
merged 1 commit into from
Jan 2, 2024
Merged

chore: move some attachment logic to global state #5653

merged 1 commit into from
Jan 2, 2024

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Jan 2, 2024

No description provided.

@st3iny st3iny added the 3. to review Waiting for reviews label Jan 2, 2024
@st3iny st3iny requested a review from ChristophWurst January 2, 2024 11:14
@st3iny st3iny self-assigned this Jan 2, 2024
@st3iny
Copy link
Member Author

st3iny commented Jan 2, 2024

/backport to stable4.6

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request A backport was requested for this pull request label Jan 2, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 2, 2024 •
edited
Loading

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (d8ed0ff) 24.44% compared to head (07c15f7) 24.44%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/services/attachmentService.js 10.00% 18 Missing ⚠️
src/store/settings.js 0.00% 12 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #5653   +/-   ##
=========================================
  Coverage     24.44%   24.44%           
  Complexity      418      418           
=========================================
  Files           243      243           
  Lines         10835    10859   +24     
  Branches       1776     1780    +4     
=========================================
+ Hits           2649     2655    +6     
- Misses         8186     8204   +18
Flag Coverage Δ
javascript 15.52% <6.25%> (+0.02%) ⬆️
php 61.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st3iny st3iny force-pushed the chore/refactor-attachment-global-store branch from f042609 to c84a0ab Compare January 2, 2024 15:48
@ChristophWurst ChristophWurst force-pushed the chore/refactor-attachment-global-store branch from c84a0ab to 07c15f7 Compare January 2, 2024 18:01
ChristophWurst
ChristophWurst approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested & works after rebase to latest main

@ChristophWurst ChristophWurst merged commit 1b88d05 into main Jan 2, 2024
36 of 37 checks passed
@ChristophWurst ChristophWurst deleted the chore/refactor-attachment-global-store branch January 2, 2024 18:14
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 2, 2024
Merged
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request A backport was requested for this pull request label Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

Assignees

@st3iny st3iny

Labels
3. to review Waiting for reviews
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@st3iny @ChristophWurst