Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow apps to hook into fullcalendar rendering process #1565

Closed
wants to merge 1 commit into from

Conversation

georgehrke
Copy link
Member

fixes #812

@georgehrke georgehrke added the 2. developing Work in progress label Oct 22, 2019
@georgehrke
Copy link
Member Author

@skjnldsv In the server, you refactored the sidebar and allow apps to hook their own vue module into it, right?

Do you mind pointing me to the specific code? I would like the same for the calendar app.

@skjnldsv
Copy link
Member

@skjnldsv In the server, you refactored the sidebar and allow apps to hook their own vue module into it, right?

Sure :)
It's not in yet, But I used a dedicated class that is bound to the data of a vue component (injecting their observer magic) allow you to watch external data from vue apps ;)
https://github.com/nextcloud/server/blob/be6ea73e6af2188e73fbf0deb7af06fb21a2460b/apps/files/src/services/Sidebar.js#L30
https://github.com/nextcloud/server/blob/be6ea73e6af2188e73fbf0deb7af06fb21a2460b/apps/files/src/sidebar.js#L35
https://github.com/nextcloud/server/blob/be6ea73e6af2188e73fbf0deb7af06fb21a2460b/apps/files/src/views/Sidebar.vue#L76

Let me know if you have questions, it's working fine and I think it's pretty straightforward and clean :)

@ChristophWurst
Copy link
Member

While I'm happy to add those events there hasn't been much activity for a long time, so I'm closing this. @skjnldsv if we need this again then let's just revive the changes or start from scratch (there are conflicts by now).

@ChristophWurst ChristophWurst deleted the feature/812/apis branch February 10, 2021 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

APIs for other apps
3 participants