Show note #3121

tobiasKaminsky · 2018-10-09T06:38:00Z

This shows a note, if available, in file detail sharing fragment.
As it is only shown if a note is available, it is out of the box backward compatible.

Requires PR for server: nextcloud/server#12978

AndyScherzinger · 2018-12-06T09:39:10Z

@tobiasKaminsky corresponding lib change has been merged to master branch and jitpack build has been triggered and turned green, so jitpack lib master will ship the lib change now 👍

AndyScherzinger · 2019-01-23T09:31:05Z

pinging @schiessle for feedback/input ❤️

tobiasKaminsky · 2019-02-15T08:32:26Z

Is the note "ShareAble" good enough to recognize? (both on Android / web UI)

AndyScherzinger · 2019-02-15T08:41:39Z

Is the note "ShareAble" good enough to recognize? (both on Android / web UI)

I don't think so to be honest. It could maybe have the text file icon or something. Maybe @nextcloud/designers have a nice idea?

codecov · 2019-02-15T09:40:25Z

Codecov Report

❗ No coverage uploaded for pull request base (showSharedUser@191e12a). Click here to learn what that means.
The diff coverage is 18.18%.

@@               Coverage Diff                @@
##             showSharedUser   #3121   +/-   ##
================================================
  Coverage                  ?   6.18%           
  Complexity                ?       1           
================================================
  Files                     ?     317           
  Lines                     ?   30602           
  Branches                  ?    4397           
================================================
  Hits                      ?    1894           
  Misses                    ?   28422           
  Partials                  ?     286

Impacted Files	Coverage Δ	Complexity Δ
...ain/java/com/owncloud/android/db/ProviderMeta.java	`88% <ø> (ø)`	`0 <0> (?)`
...ncloud/android/ui/fragment/OCFileListFragment.java	`0% <ø> (ø)`	`0 <0> (?)`
...a/com/owncloud/android/utils/FileStorageUtils.java	`12.3% <0%> (ø)`	`0 <0> (?)`
...wncloud/android/providers/FileContentProvider.java	`15.25% <0%> (ø)`	`0 <0> (?)`
...android/ui/fragment/FileDetailSharingFragment.java	`0% <0%> (ø)`	`0 <0> (?)`
...in/java/com/owncloud/android/datamodel/OCFile.java	`59.55% <100%> (ø)`	`0 <0> (?)`
...loud/android/datamodel/FileDataStorageManager.java	`10.74% <50%> (ø)`	`0 <0> (?)`

codecov · 2019-02-15T09:40:25Z

Codecov Report

Merging #3121 into master will increase coverage by 0.05%.
The diff coverage is 4.34%.

@@             Coverage Diff             @@
##             master   #3121      +/-   ##
===========================================
+ Coverage      6.26%   6.31%   +0.05%     
  Complexity        1       1              
===========================================
  Files           318     318              
  Lines         31189   31214      +25     
  Branches       4467    4469       +2     
===========================================
+ Hits           1954    1972      +18     
- Misses        28942   28948       +6     
- Partials        293     294       +1

Impacted Files	Coverage Δ	Complexity Δ
...ain/java/com/owncloud/android/db/ProviderMeta.java	`88% <ø> (ø)`	`0 <0> (ø)`	⬇️
...loud/android/datamodel/ThumbnailsCacheManager.java	`15.08% <ø> (ø)`	`0 <0> (ø)`	⬇️
...ncloud/android/ui/fragment/FileDetailFragment.java	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
...a/com/owncloud/android/utils/FileStorageUtils.java	`8% <0%> (-0.05%)`	`0 <0> (ø)`
...cloud/android/ui/adapter/FileDetailTabAdapter.java	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
...owncloud/android/ui/adapter/OCFileListAdapter.java	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
...wncloud/android/providers/FileContentProvider.java	`18.9% <0%> (-0.23%)`	`0 <0> (ø)`
...android/ui/fragment/FileDetailSharingFragment.java	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
...in/java/com/owncloud/android/datamodel/OCFile.java	`59.36% <100%> (+0.18%)`	`0 <0> (ø)`	⬇️
...loud/android/datamodel/FileDataStorageManager.java	`11.78% <50%> (+0.12%)`	`0 <0> (ø)`	⬇️
... and 4 more

jancborchardt · 2019-02-22T10:57:27Z

Is the note "ShareAble" good enough to recognize? (both on Android / web UI)

I don't think so to be honest. It could maybe have the text file icon or something. Maybe @nextcloud/designers have a nice idea?

I’d say it’s good for the first pass – normally the note has some more explanatory content than just a word, and it’s inherently understandable as a note.

If we see it’s a problem in actual use, we can always add .icon-edit, the text document icon we also use for the "Add note" menu entry.

AndyScherzinger · 2019-02-25T11:50:10Z

@tobiasKaminsky needs a rebase and one question: is this ready to merge or does it need the server PR to be merged?

tobiasKaminsky · 2019-02-26T10:23:37Z

@tobiasKaminsky needs a rebase and one question: is this ready to merge or does it need the server PR to be merged?

This originally depended on #3320, but I rebased it onto master, which now results in duplicated classes/additions, so I would like to merge #3320 before this.
After merge of #3320 I'll do a rebase.

This still requires nextcloud/server#12978 to be merged.
Backward compability should be working out of the box as older server just do not respond to "nc:note".
But I'll test it then.

(sorry for the confusion)

AndyScherzinger · 2019-03-01T07:34:14Z

src/main/java/com/owncloud/android/datamodel/ThumbnailsCacheManager.java

@@ -872,6 +873,16 @@ Drawable doAvatarInBackground() {

            int px = getAvatarDimension();

+            boolean notOnSameServer = false;
+
+            if (notOnSameServer) {


@tobiasKaminsky this is always false...

Good question, why I did this.
Maybe to test…
I'll fix it.

We ignore this for now. If there is a federated share, only the text generated avatar will be shown.
Ref: nextcloud/server#14564

AndyScherzinger · 2019-03-01T07:36:24Z

src/main/res/layout/file_details_sharing_fragment.xml

@@ -1,5 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
-<!--
+<?xml version="1.0" encoding="utf-8"?><!--


linebreak before the comment :)

AndyScherzinger · 2019-03-01T07:37:39Z

@tobiasKaminsky just two minor comments plus needs-rebase :)

AndyScherzinger · 2019-03-05T22:49:42Z

@tobiasKaminsky see review comments :)

AndyScherzinger · 2019-03-19T08:13:24Z

@tobiasKaminsky rebase 'n' merge? ❤️

tobiasKaminsky · 2019-03-19T12:14:53Z

Not quite…the part with federated icons is still open.
I hope I find time tomorrow :/

Signed-off-by: tobiasKaminsky <[email protected]>

tobiasKaminsky · 2019-03-20T07:27:14Z

Finally done :-)

nextcloud-android-bot · 2019-03-20T07:30:18Z

Lint

Type	master	PR
Warnings	68	68
Errors	0	0

FindBugs (new)

Warning Type	Number
Bad practice Warnings	33
Correctness Warnings	118
Internationalization Warnings	15
Malicious code vulnerability Warnings	5
Multithreaded correctness Warnings	9
Performance Warnings	119
Security Warnings	56
Dodgy code Warnings	120
Total	475

FindBugs (master)

Warning Type	Number
Bad practice Warnings	33
Correctness Warnings	118
Internationalization Warnings	15
Malicious code vulnerability Warnings	5
Multithreaded correctness Warnings	9
Performance Warnings	119
Security Warnings	56
Dodgy code Warnings	120
Total	475

tobiasKaminsky added the 2. developing label Oct 9, 2018

tobiasKaminsky force-pushed the sendNote branch 2 times, most recently from 6f699a2 to 2630ab7 Compare October 24, 2018 08:41

AndyScherzinger force-pushed the sendNote branch from 9426b76 to 44896ba Compare October 24, 2018 16:54

tobiasKaminsky force-pushed the showNote branch from 3a4ed62 to 6f29ad1 Compare October 25, 2018 14:33

nextcloud deleted a comment Oct 26, 2018

tobiasKaminsky changed the base branch from sendNote to master October 26, 2018 06:43

tobiasKaminsky force-pushed the showNote branch 3 times, most recently from 584978c to bfada77 Compare December 6, 2018 07:46

tobiasKaminsky changed the base branch from master to showSharedUser December 6, 2018 07:46

tobiasKaminsky mentioned this pull request Dec 6, 2018

Add note to file listing nextcloud/android-library#204

Merged

nextcloud deleted a comment Dec 6, 2018

AndyScherzinger added the needs info Waiting for info from user(s). Issues with this label will auto-stale. label Jan 23, 2019

nextcloud deleted a comment Feb 13, 2019

tobiasKaminsky force-pushed the showNote branch from e5b66be to dcf3376 Compare February 15, 2019 09:40

nextcloud deleted a comment Feb 16, 2019

tobiasKaminsky force-pushed the showNote branch from dcf3376 to 219a332 Compare February 25, 2019 08:10

tobiasKaminsky changed the base branch from showSharedUser to master February 25, 2019 08:10

nextcloud deleted a comment Feb 25, 2019

tobiasKaminsky added 3. to review and removed 2. developing needs info Waiting for info from user(s). Issues with this label will auto-stale. labels Feb 28, 2019

tobiasKaminsky force-pushed the showNote branch from 219a332 to 63c4572 Compare February 28, 2019 10:22

nextcloud deleted a comment Feb 28, 2019

AndyScherzinger requested changes Mar 1, 2019

View reviewed changes

AndyScherzinger force-pushed the showNote branch from 63c4572 to 2a75b21 Compare March 7, 2019 09:22

nextcloud deleted a comment Mar 7, 2019

show notes on receiving shares

92bbcfb

Signed-off-by: tobiasKaminsky <[email protected]>

tobiasKaminsky force-pushed the showNote branch from 2a75b21 to 92bbcfb Compare March 20, 2019 07:27

nextcloud deleted a comment Mar 20, 2019

AndyScherzinger approved these changes Mar 20, 2019

View reviewed changes

AndyScherzinger merged commit 01acf65 into master Mar 20, 2019

AndyScherzinger deleted the showNote branch March 20, 2019 09:01

AndyScherzinger added this to the Nextcloud App 3.6.0 milestone Mar 20, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show note #3121

Show note #3121

tobiasKaminsky commented Oct 9, 2018 •

edited

Loading

AndyScherzinger commented Dec 6, 2018 •

edited

Loading

AndyScherzinger commented Jan 23, 2019

tobiasKaminsky commented Feb 15, 2019

AndyScherzinger commented Feb 15, 2019

codecov bot commented Feb 15, 2019

codecov bot commented Feb 15, 2019 •

edited

Loading

jancborchardt commented Feb 22, 2019

AndyScherzinger commented Feb 25, 2019

tobiasKaminsky commented Feb 26, 2019

AndyScherzinger Mar 1, 2019

tobiasKaminsky Mar 6, 2019

tobiasKaminsky Mar 20, 2019

AndyScherzinger Mar 1, 2019

AndyScherzinger commented Mar 1, 2019

AndyScherzinger commented Mar 5, 2019

AndyScherzinger commented Mar 19, 2019

tobiasKaminsky commented Mar 19, 2019

tobiasKaminsky commented Mar 20, 2019

nextcloud-android-bot commented Mar 20, 2019

Show note #3121

Show note #3121

Conversation

tobiasKaminsky commented Oct 9, 2018 • edited Loading

AndyScherzinger commented Dec 6, 2018 • edited Loading

AndyScherzinger commented Jan 23, 2019

tobiasKaminsky commented Feb 15, 2019

AndyScherzinger commented Feb 15, 2019

codecov bot commented Feb 15, 2019

Codecov Report

codecov bot commented Feb 15, 2019 • edited Loading

Codecov Report

jancborchardt commented Feb 22, 2019

AndyScherzinger commented Feb 25, 2019

tobiasKaminsky commented Feb 26, 2019

AndyScherzinger Mar 1, 2019

Choose a reason for hiding this comment

tobiasKaminsky Mar 6, 2019

Choose a reason for hiding this comment

tobiasKaminsky Mar 20, 2019

Choose a reason for hiding this comment

AndyScherzinger Mar 1, 2019

Choose a reason for hiding this comment

AndyScherzinger commented Mar 1, 2019

AndyScherzinger commented Mar 5, 2019

AndyScherzinger commented Mar 19, 2019

tobiasKaminsky commented Mar 19, 2019

tobiasKaminsky commented Mar 20, 2019

nextcloud-android-bot commented Mar 20, 2019

Lint

FindBugs (new)

FindBugs (master)

tobiasKaminsky commented Oct 9, 2018 •

edited

Loading

AndyScherzinger commented Dec 6, 2018 •

edited

Loading

codecov bot commented Feb 15, 2019 •

edited

Loading