-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix: handle slow internet connection better for fetching shares #15756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alperozturk96
wants to merge
7
commits into
master
Choose a base branch
from
fix/handle-slow-internet-connection-better-for-fetching-shares
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: handle slow internet connection better for fetching shares #15756
alperozturk96
wants to merge
7
commits into
master
from
fix/handle-slow-internet-connection-better-for-fetching-shares
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@tobiasKaminsky I’m unable to fetch shares from the |
d75ad64
to
83b48f2
Compare
kra-mo
approved these changes
Oct 16, 2025
Signed-off-by: alperozturk <[email protected]> # Conflicts: # build.gradle
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
83b48f2
to
076b7e1
Compare
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15756.apk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When the internet connection is slow or the server responds slowly, the search task may fail, but the file list incorrectly displays as "No files here," giving users a misleading impression that no files exist.
How to reproduce?
Changes
New empty list state: Added a dedicated state to accurately reflect the current status of the screen.
Replaces
AsyncTask
withCoroutines
for better and easy state management.Increases session timeout
Fixes since
OCFileListSearchTask
triggersshowFederatedShareAvatar
:Library PR: nextcloud/android-library#1857