Shows favorite state in share overview

[tobiasKaminsky]

Uses: nextcloud/android-library#968

Signed-off-by: tobiasKaminsky [email protected]

• Tests written, or not not needed

[AlvaroBrey]

/rebase

[tobiasKaminsky]

Hm. there is something not compiling.
Let me check that.

[tobiasKaminsky]

Seems that rebase of library was a bit too late

[codecov]

Codecov Report

Merging #11138 (e2ae54b) into master (59bfe0d) will increase coverage by 27.77%.
The diff coverage is 100.00%.

❗ Current head e2ae54b differs from pull request most recent head 4f1d034. Consider uploading reports for the commit 4f1d034 to get more accurate results

Additional details and impacted files

@@              Coverage Diff              @@
##             master   #11138       +/-   ##
=============================================
+ Coverage      3.23%   31.00%   +27.77%     
- Complexity      437     3323     +2886     
=============================================
  Files           566      565        -1     
  Lines         41614    41578       -36     
  Branches       5630     5635        +5     
=============================================
+ Hits           1347    12893    +11546     
+ Misses        40180    26763    -13417     
- Partials         87     1922     +1835     

Impacted Files	Coverage Δ
...oud/android/ui/adapter/OCShareToOCFileConverter.kt	92.85% <100.00%> (+0.26%)	⬆️
.../java/com/owncloud/android/datamodel/GalleryRow.kt	50.00% <0.00%> (ø)
...a/com/owncloud/android/media/MediaControlView.java	0.00% <0.00%> (ø)
...om/owncloud/android/ui/activity/EditorWebView.java	0.00% <0.00%> (ø)
...loud/android/utils/svg/SvgSoftwareLayerSetter.java	0.00% <0.00%> (ø)
.../android/ui/dialog/ChooseTemplateDialogFragment.kt	0.00% <0.00%> (ø)
...ndroid/ui/activity/RichDocumentsEditorWebView.java	0.00% <0.00%> (ø)
...droid/ui/dialog/SetupEncryptionDialogFragment.java	0.00% <0.00%> (ø)
...g/java/com/nextcloud/test/InjectionTestActivity.kt
.../src/debug/java/com/nextcloud/test/TestActivity.kt
... and 289 more

[tobiasKaminsky]

/rebase

[github-actions]

blue-Light-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/11138-Screenshot-blue-Light-13-08

[nextcloud-android-bot]

stable-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/7532-IT-stable-10-43

[nextcloud-android-bot]

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/7532-IT-master-10-50

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	76	76
Errors	0	0

SpotBugs

Category	Base	New
Bad practice	27	27
Correctness	44	44
Dodgy code	334	334
Internationalization	9	9
Multithreaded correctness	9	9
Performance	58	58
Security	18	18
Total	499	499

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11138.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/11138-Screenshot-blue-Light-11-43