Skip to content

Parse favorite attribute for OCShare on NC 25+ #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Parse favorite attribute for OCShare on NC 25+ #968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
108 changes: 108 additions & 0 deletions ...ndroidTest/java/com/owncloud/android/lib/resources/shares/GetSharesRemoteOperationIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
import static junit.framework.TestCase.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
import static org.junit.Assume.assumeTrue;

import android.net.Uri;
import android.os.Bundle;
Expand All @@ -42,6 +43,12 @@
import com.owncloud.android.lib.common.OwnCloudClientFactory;
import com.owncloud.android.lib.common.operations.RemoteOperationResult;
import com.owncloud.android.lib.resources.files.CreateFolderRemoteOperation;
import com.owncloud.android.lib.resources.files.ToggleFavoriteRemoteOperation;
import com.owncloud.android.lib.resources.status.GetCapabilitiesRemoteOperation;
import com.owncloud.android.lib.resources.status.NextcloudVersion;
import com.owncloud.android.lib.resources.status.OCCapability;

import junit.framework.TestCase;

import org.junit.Test;

Expand Down Expand Up @@ -223,4 +230,105 @@ public void sharedWithMe() {
resultSharedWithMe = sutSharedWithMe.execute(client);
assertEquals(1, resultSharedWithMe.getResultData().size());
}

@Test
public void favorites() {
// only on NC25+
OCCapability ocCapability = (OCCapability) new GetCapabilitiesRemoteOperation()
.execute(nextcloudClient).getSingleData();
assumeTrue(ocCapability.getVersion().isNewerOrEqual(NextcloudVersion.nextcloud_25));

// share folder to user "admin"
assertTrue(new CreateFolderRemoteOperation("/shareToAdminNoFavorite/", true).execute(client).isSuccess());
RemoteOperationResult<List<OCShare>> createResult = new CreateShareRemoteOperation("/shareToAdminNoFavorite/",
ShareType.USER,
"admin",
false,
"",
OCShare.MAXIMUM_PERMISSIONS_FOR_FOLDER,
true)
.execute(client);

assertTrue(createResult.isSuccess());

String path = "/shareToAdminFavorite/";
assertTrue(new CreateFolderRemoteOperation(path, true).execute(client).isSuccess());

// favorite it
TestCase.assertTrue(new ToggleFavoriteRemoteOperation(true, path).execute(client).isSuccess());

// share folder to user "admin"
createResult = new CreateShareRemoteOperation(path,
ShareType.USER,
"admin",
false,
"",
OCShare.MAXIMUM_PERMISSIONS_FOR_FOLDER,
true)
.execute(client);

assertTrue(createResult.isSuccess());

// check
RemoteOperationResult<List<OCShare>> sut = new GetSharesRemoteOperation(false).execute(client);
assertEquals(2, sut.getResultData().size());
assertFalse(sut.getResultData().get(0).isFavorite());
assertTrue(sut.getResultData().get(1).isFavorite());
}

@Test
public void noFavorite() {
// only on NC25+
OCCapability ocCapability = (OCCapability) new GetCapabilitiesRemoteOperation()
.execute(nextcloudClient).getSingleData();
assumeTrue(ocCapability.getVersion().isNewerOrEqual(NextcloudVersion.nextcloud_25));

assertTrue(new CreateFolderRemoteOperation("/shareToAdminNoFavorite/", true).execute(client).isSuccess());

// share folder to user "admin"
RemoteOperationResult<List<OCShare>> createResult = new CreateShareRemoteOperation("/shareToAdminNoFavorite/",
ShareType.USER,
"admin",
false,
"",
OCShare.MAXIMUM_PERMISSIONS_FOR_FOLDER,
true)
.execute(client);

assertTrue(createResult.isSuccess());

OCShare share = createResult.getResultData().get(0);

assertFalse(share.isFavorite());
}

@Test
public void favorite() {
// only on NC25+
OCCapability ocCapability = (OCCapability) new GetCapabilitiesRemoteOperation()
.execute(nextcloudClient).getSingleData();
assumeTrue(ocCapability.getVersion().isNewerOrEqual(NextcloudVersion.nextcloud_25));

String path = "/shareToAdminFavorite/";
assertTrue(new CreateFolderRemoteOperation(path, true).execute(client).isSuccess());

// favorite it
TestCase.assertTrue(new ToggleFavoriteRemoteOperation(true, path).execute(client).isSuccess());

// share folder to user "admin"
RemoteOperationResult<List<OCShare>> createResult = new CreateShareRemoteOperation(path,
ShareType.USER,
"admin",
false,
"",
OCShare.MAXIMUM_PERMISSIONS_FOR_FOLDER,
true)
.execute(client);

assertTrue(createResult.isSuccess());

OCShare share = createResult.getResultData().get(0);

assertTrue(share.isFavorite());
}
}
Loading