Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Sep 5, 2022

Needed by nextcloud/android#10713

Signed-off-by: tobiasKaminsky [email protected]

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2022

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 39
Total 149

SpotBugs (master)

Warning Type Number
Bad practice Warnings 17
Correctness Warnings 36
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 13
Security Warnings 1
Dodgy code Warnings 45
Total 164

AlvaroBrey
AlvaroBrey previously approved these changes Sep 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 39
Total 149

SpotBugs (master)

Warning Type Number
Bad practice Warnings 17
Correctness Warnings 36
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 13
Security Warnings 1
Dodgy code Warnings 45
Total 164

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 39
Total 149

SpotBugs (master)

Warning Type Number
Bad practice Warnings 17
Correctness Warnings 36
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 13
Security Warnings 1
Dodgy code Warnings 45
Total 164

AlvaroBrey
AlvaroBrey previously approved these changes Sep 12, 2022
@AlvaroBrey AlvaroBrey changed the title change key handling Add RemoteOperation to delete encryption keys Dec 13, 2022
@AlvaroBrey
Copy link
Member

Rebased and conflicts fixed

AlvaroBrey
AlvaroBrey previously approved these changes Dec 13, 2022
@github-actions
Copy link
Contributor

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

@tobiasKaminsky
Copy link
Member Author

/rebase

@github-actions
Copy link
Contributor

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #959 (be24e92) into master (78f36c8) will increase coverage by 0.28%.
The diff coverage is 49.56%.

❗ Current head be24e92 differs from pull request most recent head f677f4e. Consider uploading reports for the commit f677f4e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #959      +/-   ##
==========================================
+ Coverage   48.70%   48.99%   +0.28%     
==========================================
  Files         171      178       +7     
  Lines        6611     6687      +76     
  Branches      881      886       +5     
==========================================
+ Hits         3220     3276      +56     
- Misses       2922     2940      +18     
- Partials      469      471       +2     
Impacted Files Coverage Δ
...oid/lib/resources/dashboard/DashboardWidgetList.kt 0.00% <0.00%> (ø)
...diting/DirectEditingCreateFileRemoteOperation.java 76.47% <ø> (ø)
...ctEditingObtainListOfTemplatesRemoteOperation.java 68.00% <ø> (ø)
...ectediting/DirectEditingObtainRemoteOperation.java 63.63% <ø> (ø)
...tediting/DirectEditingOpenFileRemoteOperation.java 81.48% <ø> (ø)
...b/resources/profile/GetHoverCardRemoteOperation.kt 62.50% <ø> (ø)
...es/search/UnifiedSearchProvidersRemoteOperation.kt 48.14% <ø> (ø)
...rces/users/GenerateAppPasswordRemoteOperation.java 77.27% <ø> (ø)
...ace/RichWorkspaceDirectEditingRemoteOperation.java 72.41% <ø> (ø)
.../main/java/com/nextcloud/common/NextcloudClient.kt 57.14% <ø> (ø)
... and 42 more

AlvaroBrey
AlvaroBrey previously approved these changes Dec 15, 2022
@tobiasKaminsky tobiasKaminsky force-pushed the deleteEncryptedKeys branch 2 times, most recently from f677f4e to 1505b61 Compare January 5, 2023 08:17
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

Signed-off-by: tobiasKaminsky <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

@tobiasKaminsky tobiasKaminsky merged commit 53c5c98 into master Jan 5, 2023
@delete-merged-branch delete-merged-branch bot deleted the deleteEncryptedKeys branch January 5, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants