Switching to dav4jvm #881

tobiasKaminsky · 2022-05-02T12:43:46Z

Heavily under construction 🚧
If you have any feedback, please comment :)

Signed-off-by: tobiasKaminsky [email protected]

tobiasKaminsky · 2022-05-05T13:15:38Z

@AlvaroBrey if you have a bit of time, any feedback would be great 💙

library/src/main/java/com/nextcloud/common/NextcloudClient.kt

library/src/main/java/com/nextcloud/operations/dav/OkHttpDavMethodBase.kt

library/src/main/java/com/nextcloud/common/NextcloudClient.kt

library/src/main/java/com/owncloud/android/lib/common/operations/RemoteOperationResult.java

library/src/main/java/com/nextcloud/operations/dav/PropFindMethod.kt

AlvaroBrey

Unused submodule?

library/src/androidTest/java/com/owncloud/android/Dav4JVM.kt

library/src/androidTest/java/com/owncloud/android/AbstractIT.java

library/src/main/java/com/nextcloud/common/NextcloudAuthenticator.java

library/src/main/java/com/owncloud/android/lib/common/network/WebdavUtils.java

AlvaroBrey · 2022-12-13T14:53:30Z

library/src/main/java/com/owncloud/android/lib/common/network/WebdavUtils.java

        return result;
    }

+    public static void registerCustomFactories() {


As we're working on a static singleton (PropertyRegistry.INSTANCE), I guess it would be better to initialize this list in a static block in order to avoid having to call it explicitly on clients.

AlvaroBrey · 2022-12-13T15:29:48Z

library/src/main/java/com/owncloud/android/lib/resources/files/SearchRemoteOperation.java

+            OkHttpClient disabledRedirectClient = client.getClient()
+                    .newBuilder()
+                    .followRedirects(false)
+                    .authenticator(new NextcloudAuthenticator(client.getCredentials(), "Authorization"))
+                    .build();


I don't think it's a good idea to create a new OkHttpClient for every request... the NextcloudClient passed to run should already be authenticated IMO. Not sure about the redirects or why they are disabled.

AlvaroBrey · 2022-12-13T15:39:23Z

library/src/main/java/com/owncloud/android/lib/resources/files/SearchRemoteOperation.java

+            if (searchMethod != null) {
+                searchMethod.releaseConnection();  // let the connection available for other methods
+            }


This does not seem necessary, as the search method is never called (only used to get the query string)

...ry/src/main/java/com/owncloud/android/lib/resources/files/ToggleFavoriteRemoteOperation.java

library/src/main/java/com/owncloud/android/lib/resources/status/OCCapability.kt

github-actions · 2024-08-20T08:25:34Z

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	31
Dodgy code	26	27
Internationalization	6	4
Malicious code vulnerability	49	44
Multithreaded correctness	3	3
Performance	8	8
Security	0	2
Total	161	154

codecov · 2024-08-20T11:02:23Z

Codecov Report

Attention: Patch coverage is 66.07362% with 553 lines in your changes missing coverage. Please review.

Project coverage is 51.19%. Comparing base (bf33890) to head (4f7f56d).

Files	Patch %	Lines
...oid/lib/common/operations/RemoteOperationResult.kt	52.03%	94 Missing and 59 partials ⚠️
...ud/android/lib/resources/files/model/RemoteFile.kt	25.71%	23 Missing and 3 partials ⚠️
...owncloud/android/lib/common/network/WebdavEntry.kt	62.50%	20 Missing and 4 partials ⚠️
...ncloud/android/lib/common/utils/WebDavFileUtils.kt	72.22%	9 Missing and 11 partials ⚠️
...c/main/java/com/nextcloud/operations/MoveMethod.kt	0.00%	17 Missing ⚠️
...ud/android/lib/resources/files/webdav/NCSharees.kt	70.21%	2 Missing and 12 partials ⚠️
...owncloud/android/lib/common/network/WebdavUtils.kt	92.44%	6 Missing and 7 partials ⚠️
...cloud/android/lib/resources/files/webdav/NCTags.kt	70.00%	7 Missing and 5 partials ⚠️
...b/resources/files/webdav/NCTrashbinDeletionTime.kt	23.07%	10 Missing ⚠️
...d/lib/resources/files/webdav/NCTrashbinFilename.kt	23.07%	10 Missing ⚠️
... and 59 more

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #881      +/-   ##
============================================
+ Coverage     49.16%   51.19%   +2.03%     
- Complexity     1000     1147     +147     
============================================
  Files           208      256      +48     
  Lines          7819     8372     +553     
  Branches       1017     1107      +90     
============================================
+ Hits           3844     4286     +442     
- Misses         3421     3464      +43     
- Partials        554      622      +68

Files	Coverage Δ
...ces/groupfolders/GetGroupfoldersRemoteOperation.kt	`61.29% <100.00%> (ø)`
...b/resources/profile/GetHoverCardRemoteOperation.kt	`57.14% <100.00%> (ø)`
...ry/src/main/java/com/nextcloud/common/DavMethod.kt	`100.00% <100.00%> (ø)`
.../main/java/com/nextcloud/common/NextcloudClient.kt	`50.45% <100.00%> (+3.92%)`	⬆️
...main/java/com/nextcloud/common/OkHttpMethodBase.kt	`64.81% <ø> (-1.26%)`	⬇️
.../java/com/nextcloud/common/UserAgentInterceptor.kt	`100.00% <100.00%> (ø)`
...n/java/com/nextcloud/extensions/ArrayExtensions.kt	`100.00% <100.00%> (ø)`
...in/java/com/nextcloud/operations/PropFindResult.kt	`100.00% <100.00%> (ø)`
...rc/main/java/com/nextcloud/operations/PutMethod.kt	`83.33% <100.00%> (+11.90%)`	⬆️
...d/android/lib/common/network/ExtendedProperties.kt	`100.00% <100.00%> (ø)`
... and 83 more

... and 5 files with indirect coverage changes

github-actions · 2024-08-20T11:09:40Z

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	31
Dodgy code	26	27
Internationalization	6	4
Malicious code vulnerability	49	44
Multithreaded correctness	3	3
Performance	8	8
Security	0	2
Total	161	154

github-actions · 2024-08-21T13:23:18Z

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	31
Dodgy code	26	27
Internationalization	6	4
Malicious code vulnerability	49	44
Multithreaded correctness	3	3
Performance	8	8
Security	0	2
Total	161	154

Signed-off-by: tobiasKaminsky <[email protected]>

github-actions · 2024-10-30T14:36:07Z

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	31
Dodgy code	26	27
Internationalization	6	4
Malicious code vulnerability	49	44
Multithreaded correctness	3	3
Performance	8	8
Security	0	2
Total	161	154

Signed-off-by: tobiasKaminsky <[email protected]>

github-actions · 2024-10-31T14:22:36Z

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	31
Dodgy code	26	27
Internationalization	6	4
Malicious code vulnerability	49	44
Multithreaded correctness	3	3
Performance	8	8
Security	0	2
Total	161	154

nextcloud-android-bot · 2024-10-31T15:01:52Z

stable-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/3424-IT-stable-15-01/debug/

nextcloud-android-bot · 2024-10-31T15:06:37Z

master-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/3424-IT-master-15-05/debug/

tobiasKaminsky force-pushed the dav4jvm branch from 83fa188 to d56c428 Compare May 5, 2022 13:14

AlvaroBrey reviewed May 5, 2022

View reviewed changes

AlvaroBrey force-pushed the dav4jvm branch from 1f03609 to 8fd7eb3 Compare July 1, 2022 08:39

github-actions bot deleted a comment from nextcloud-android-bot Jul 1, 2022

tobiasKaminsky force-pushed the dav4jvm branch from 8fd7eb3 to 39fcd31 Compare October 6, 2022 13:05

tobiasKaminsky force-pushed the dav4jvm branch 2 times, most recently from c674812 to 6549214 Compare October 14, 2022 05:10

tobiasKaminsky mentioned this pull request Oct 14, 2022

Use android-library, streamline dav4jvm nextcloud/talk-android#2497

Draft

2 tasks

tobiasKaminsky requested a review from AlvaroBrey November 1, 2022 11:55

tobiasKaminsky force-pushed the dav4jvm branch from a70b71f to 48671c8 Compare November 1, 2022 11:57

github-actions bot deleted a comment from nextcloud-android-bot Nov 1, 2022

tobiasKaminsky force-pushed the dav4jvm branch from 48671c8 to 0fe738a Compare November 1, 2022 12:00

github-actions bot deleted a comment from nextcloud-android-bot Nov 3, 2022

tobiasKaminsky force-pushed the dav4jvm branch from a0d8ab7 to d2dc89e Compare December 12, 2022 14:58

github-actions bot deleted a comment from nextcloud-android-bot Dec 12, 2022

github-actions bot deleted a comment from nextcloud-android-bot Dec 13, 2022

AlvaroBrey reviewed Dec 13, 2022

View reviewed changes

AlvaroBrey mentioned this pull request Jan 20, 2023

Connection fails when server sends compressed responses nextcloud/android#11212

Closed

4 tasks

tobiasKaminsky mentioned this pull request Aug 31, 2023

v2 Roadmap #815

Open

7 tasks

nextcloud deleted a comment from github-actions bot Sep 4, 2023

tobiasKaminsky force-pushed the dav4jvm branch from a90a4b7 to 074035e Compare September 4, 2023 10:00

tobiasKaminsky force-pushed the dav4jvm branch from 074035e to eaec6d5 Compare October 12, 2023 08:14

tobiasKaminsky force-pushed the dav4jvm branch from eaec6d5 to c36189c Compare January 30, 2024 13:22

AndyScherzinger added the 2. developing label Feb 12, 2024

AndyScherzinger marked this pull request as ready for review February 12, 2024 22:02

AndyScherzinger force-pushed the dav4jvm branch from c36189c to e8885c3 Compare February 12, 2024 22:03

ZetaTom force-pushed the dav4jvm branch from e8885c3 to bf6cc1b Compare February 13, 2024 12:56

ZetaTom force-pushed the dav4jvm branch 2 times, most recently from 5ae2701 to a684a16 Compare March 11, 2024 12:46

nextcloud deleted a comment from github-actions bot Aug 20, 2024

nextcloud deleted a comment from nextcloud-android-bot Aug 20, 2024

nextcloud deleted a comment from github-actions bot Aug 20, 2024

joshtrichards mentioned this pull request Oct 4, 2024

Unable to upload using multiple threads nextcloud/android#3865

Closed

use dav4jvm search and proppatch

017ae9d

Signed-off-by: tobiasKaminsky <[email protected]>

tobiasKaminsky force-pushed the dav4jvm branch from 4f7f56d to 017ae9d Compare October 30, 2024 14:07

tobiasKaminsky added 2 commits October 31, 2024 09:11

wip

0bb570a

Signed-off-by: tobiasKaminsky <[email protected]>

wip

1787523

Signed-off-by: tobiasKaminsky <[email protected]>

tobiasKaminsky added 2. developing and removed 3. to review labels Dec 16, 2024

Switching to dav4jvm #881

Are you sure you want to change the base?

Switching to dav4jvm #881

Uh oh!

Conversation

tobiasKaminsky commented May 2, 2022

Uh oh!

tobiasKaminsky commented May 5, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AlvaroBrey left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AlvaroBrey Dec 13, 2022

Choose a reason for hiding this comment

Uh oh!

AlvaroBrey Dec 13, 2022

Choose a reason for hiding this comment

Uh oh!

AlvaroBrey Dec 13, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Aug 20, 2024

SpotBugs

Uh oh!

codecov bot commented Aug 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Aug 20, 2024

SpotBugs

Uh oh!

github-actions bot commented Aug 21, 2024

SpotBugs

Uh oh!

github-actions bot commented Oct 30, 2024

SpotBugs

Uh oh!

github-actions bot commented Oct 31, 2024

SpotBugs

Uh oh!

nextcloud-android-bot commented Oct 31, 2024

Uh oh!

nextcloud-android-bot commented Oct 31, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Aug 20, 2024 •

edited

Loading