Skip to content

Fix user info route #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2016
Merged

Fix user info route #21

merged 2 commits into from
Oct 21, 2016

Conversation

@AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Oct 18, 2016 •
edited
Loading

Resolves #18

I`ll test drive this first. As described in #18 this is an important change since the legacy URL won't work anymore for Nextcloud 11+

cc @tobiasKaminsky

@AndyScherzinger AndyScherzinger added this to the NC Android lib 1.0.8 milestone Oct 18, 2016
@AndyScherzinger AndyScherzinger mentioned this pull request Oct 18, 2016
Closed
@AndyScherzinger
Copy link
Member Author

AndyScherzinger commented Oct 18, 2016

I tested the changed route info and it works for my server (where the old URL worked) and for the demo account that has been given to us for the server where the login didn't work and now that one works too.

@tobiasKaminsky please review and merge 😃 🚀

@AndyScherzinger
Copy link
Member Author

AndyScherzinger commented Oct 19, 2016

@tobiasKaminsky this will automatically be in your next beta release since I pushed it to the lib's beta branch

@AndyScherzinger AndyScherzinger mentioned this pull request Oct 19, 2016
Closed
@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented Oct 19, 2016

👍

@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented Oct 19, 2016

@AndyScherzinger we need a second 👍 here ;)

@AndyScherzinger
Copy link
Member Author

AndyScherzinger commented Oct 19, 2016

👍

@AndyScherzinger
Copy link
Member Author

AndyScherzinger commented Oct 19, 2016

@jancborchardt @LukasReschke can you please 👍 :)

@AndyScherzinger
Copy link
Member Author

AndyScherzinger commented Oct 19, 2016

You can merge @tobiasKaminsky

@jancborchardt
Copy link
Member

jancborchardt commented Oct 19, 2016

Can’t say anything here ;D @LukasReschke maybe

@jancborchardt
Copy link
Member

jancborchardt commented Oct 19, 2016

@AndyScherzinger or do you mean to bypass the merging 2 +1s? I can add you both as admins for the android and android-library repos.

@jancborchardt
Copy link
Member

jancborchardt commented Oct 19, 2016

Ah, you already are. :)

@AndyScherzinger
Copy link
Member Author

AndyScherzinger commented Oct 19, 2016

Bypass the 2 👍s

@AndyScherzinger
Copy link
Member Author

AndyScherzinger commented Oct 21, 2016

Works as expected and beta feedback is also positive. So merging.

@AndyScherzinger AndyScherzinger merged commit efbbb16 into master Oct 21, 2016
@AndyScherzinger AndyScherzinger deleted the userInfoRouteUpdate branch October 21, 2016 20:22
@AndyScherzinger AndyScherzinger mentioned this pull request Oct 23, 2016
Closed
surinder-tsys added a commit to nextmcloud/android-library that referenced this pull request Mar 1, 2023
@surinder-tsys
Merge pull request nextcloud#21 from surinder-tsys/dependabot/github_…
fe8c752 
…actions/cirrus-actions/rebase-1.7

Bump cirrus-actions/rebase from 1.5 to 1.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

Assignees

No one assigned

Labels

bug high

Projects

None yet

Milestone

NC lib 1.0.8

Development

Successfully merging this pull request may close these issues.

4 participants

@AndyScherzinger @tobiasKaminsky @jancborchardt