-
Notifications
You must be signed in to change notification settings - Fork 94
BugFix - DNSCache Lock #1770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
BugFix - DNSCache Lock #1770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alperozturk <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1770 +/- ##
============================================
- Coverage 43.06% 43.01% -0.05%
Complexity 987 987
============================================
Files 235 235
Lines 8569 8569
Branches 1123 1124 +1
============================================
- Hits 3690 3686 -4
- Misses 4361 4365 +4
Partials 518 518
🚀 New features to boost your workflow:
|
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
AndyScherzinger
approved these changes
Jul 15, 2025
tobiasKaminsky
approved these changes
Jul 18, 2025
|
/backport to stable-2.21 |
|
/backport to stable-2.21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
DNSCacheused@Synchronizedon all public methods to protect access to aMutableMap.All threads must acquire the lock, even for read operations like
isIPV6First()orlookup()Methods like
lookup()perform DNS resolution, which can be slow. Holding the@Synchronizedlock this increases the risk of blocking critical threads like the UI or Android system event receivers.Changes
Replaced
MutableMapwithConcurrentHashMapto enable lock-free concurrent access.Removed unnecessary
@Synchronizedannotations from all methods.Use
ConcurrentHashMap.compute(), ensuring atomic read–modify–write operations without external locking.Issue Logs