-
Notifications
You must be signed in to change notification settings - Fork 94
BugFix - Filter Only One TextInput and one TextOutput Task Types #1761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
1 task
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1761 +/- ##
============================================
- Coverage 43.09% 43.07% -0.03%
+ Complexity 989 987 -2
============================================
Files 235 235
Lines 8562 8566 +4
Branches 1119 1122 +3
============================================
Hits 3690 3690
- Misses 4358 4359 +1
- Partials 514 517 +3
🚀 New features to boost your workflow:
|
Member
|
/backport to stable-2.21 |
library/src/main/java/com/owncloud/android/lib/resources/assistant/v2/model/TaskTypes.kt
Outdated
Show resolved
Hide resolved
library/src/main/java/com/owncloud/android/lib/resources/assistant/v2/model/TaskTypes.kt
Outdated
Show resolved
Hide resolved
Contributor
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
8b138cb to
8fc329b
Compare
Contributor
tobiasKaminsky
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, on the Android client, we are retrieving task types from the
/ocs/v2.php/taskprocessing/tasktypesendpoint, and it only uses the "text" task types. However, the Chat API task type is also served from this endpoint, which requires more than a single input string, as seen here:https://github.com/nextcloud/server/blob/master/lib/public/TaskProcessing/TaskTypes/TextToTextChat.php#L70-L85.
Client & Library should filter only one text input and one text output.
Client PR: BugFix - Filter Only One TextInput and one TextOutput Task Types #15079
How to test?