Skip to content

Conversation

@alperozturk96
Copy link
Contributor

@alperozturk96 alperozturk96 commented Jul 1, 2025

Currently, on the Android client, we are retrieving task types from the /ocs/v2.php/taskprocessing/tasktypes endpoint, and it only uses the "text" task types. However, the Chat API task type is also served from this endpoint, which requires more than a single input string, as seen here:

https://github.com/nextcloud/server/blob/master/lib/public/TaskProcessing/TaskTypes/TextToTextChat.php#L70-L85.

Client & Library should filter only one text input and one text output.

Client PR: BugFix - Filter Only One TextInput and one TextOutput Task Types #15079

How to test?

  1. Set up two instances: one with Nextcloud 28 and another with Nextcloud version 30 or higher.
  2. Enable assistant app from web client
  3. Create a task and user should not be able to see the Chat task type.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2025

SpotBugs

CategoryBaseNew
Bad practice3434
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness1111
Performance88
Total168168

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2025

SpotBugs

CategoryBaseNew
Bad practice3434
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness1111
Performance88
Total168168

@codecov
Copy link

codecov bot commented Jul 1, 2025

Codecov Report

Attention: Patch coverage is 59.09091% with 9 lines in your changes missing coverage. Please review.

Project coverage is 43.07%. Comparing base (3ae4c07) to head (8fc329b).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...rces/assistant/v2/GetTaskTypesRemoteOperationV2.kt 62.50% 0 Missing and 6 partials ⚠️
...roid/lib/resources/assistant/v1/model/TaskTypes.kt 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1761      +/-   ##
============================================
- Coverage     43.09%   43.07%   -0.03%     
+ Complexity      989      987       -2     
============================================
  Files           235      235              
  Lines          8562     8566       +4     
  Branches       1119     1122       +3     
============================================
  Hits           3690     3690              
- Misses         4358     4359       +1     
- Partials        514      517       +3     
Files with missing lines Coverage Δ
...roid/lib/resources/assistant/v2/model/TaskTypes.kt 91.66% <100.00%> (-2.09%) ⬇️
...roid/lib/resources/assistant/v1/model/TaskTypes.kt 6.66% <0.00%> (ø)
...rces/assistant/v2/GetTaskTypesRemoteOperationV2.kt 64.28% <62.50%> (+2.52%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tobiasKaminsky
Copy link
Member

/backport to stable-2.21

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025

SpotBugs

CategoryBaseNew
Bad practice3434
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness1111
Performance88
Total168168

Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 alperozturk96 force-pushed the bugfix/filter-chat-type-assistant branch from 8b138cb to 8fc329b Compare July 2, 2025 09:09
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025

SpotBugs

CategoryBaseNew
Bad practice3434
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness1111
Performance88
Total168168

@tobiasKaminsky tobiasKaminsky merged commit 0edf157 into master Jul 2, 2025
18 checks passed
@tobiasKaminsky tobiasKaminsky deleted the bugfix/filter-chat-type-assistant branch July 2, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants