Skip to content

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Jun 30, 2025

Backport of PR #1724

The -1 can cause the last byte to not end up in the request body (incomplete file), causing the server to time out because it expects the content length to be one byte larger. However, this one byte that isn't loaded and isn't sent is present in the file.

I was able to successfully test this and it fixed the error for me.

Signed-off-by: Alexander-Ger-Reich <[email protected]>
@github-actions
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3434
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness1111
Performance88
Total168168

@codecov
Copy link

codecov bot commented Jun 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (stable-2.21@26236ba). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@
##             stable-2.21    #1759   +/-   ##
==============================================
  Coverage               ?   43.07%           
  Complexity             ?      988           
==============================================
  Files                  ?      235           
  Lines                  ?     8562           
  Branches               ?     1119           
==============================================
  Hits                   ?     3688           
  Misses                 ?     4359           
  Partials               ?      515           
Files with missing lines Coverage Δ
...mon/network/ChunkFromFileChannelRequestEntity.java 55.73% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tobiasKaminsky tobiasKaminsky merged commit 5fc4f1e into stable-2.21 Jul 2, 2025
15 of 16 checks passed
@tobiasKaminsky tobiasKaminsky deleted the backport/1724/stable-2.21 branch July 2, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants