Skip to content

Conversation

@ZetaTom
Copy link
Contributor

@ZetaTom ZetaTom commented Jun 16, 2025

The -1 can cause the last byte to not end up in the request body (incomplete file), causing the server to time out because it expects the content length to be one byte larger. However, this one byte that isn't loaded and isn't sent is present in the file.

I was able to successfully test this and it fixed the error for me.

This pull request is solely intended to run all CI tests of #1724, which is a community contribution by @Alexander-Ger-Reich. Due to our security policies, we cannot run CI tests on forked repositories. Consequently, all changes have been pushed to a branch within this repository. This pull request shall be closed in favour of #1724 once all tests have been completed.

The -1 can cause the last byte to not end up in the request body (incomplete file), causing the server to time out because it expects the content length to be one byte larger. However, this one byte that isn't loaded and isn't sent is present in the file.

I was able to successfully test this and it fixed the error for me.

Signed-off-by: Alexander-Ger-Reich <[email protected]>
@ZetaTom ZetaTom self-assigned this Jun 16, 2025
@github-actions
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3534
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness311
Performance88
Total161168

SpotBugs increased!

@codecov
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.09%. Comparing base (ffc47c7) to head (b56736f).
Report is 17 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1745      +/-   ##
============================================
+ Coverage     43.07%   43.09%   +0.02%     
- Complexity      988      989       +1     
============================================
  Files           235      235              
  Lines          8562     8562              
  Branches       1119     1119              
============================================
+ Hits           3688     3690       +2     
+ Misses         4359     4358       -1     
+ Partials        515      514       -1     
Files with missing lines Coverage Δ
...mon/network/ChunkFromFileChannelRequestEntity.java 55.73% <100.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@crimsonflame123
Copy link

Did this one also hit a roadblock?

@Alexander-Ger-Reich
Copy link
Contributor

Did this one also hit a roadblock?

What does Analysis do and why does it fail?

@crimsonflame123
Copy link

Did this one also hit a roadblock?

What does Analysis do and why does it fail?

I'm new to this codebase but have a look at this. Warning count has increased and theres also message about stuff becoming an error in Kotlin.

https://github.com/nextcloud/android-library/actions/runs/15683089591/job/44179251411?pr=1745

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants