Skip to content

Conversation

@alperozturk96
Copy link
Contributor

@alperozturk96 alperozturk96 commented Apr 25, 2025

Fixes

Unexpected token (position:TEXT {"ocs":{"meta":{...@1:97 in [java.io](http://java.io/).InputStreamReader@23ca098)

@github-actions
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3534
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161160

@alperozturk96 alperozturk96 force-pushed the bugfix/xml-exception-parser branch from c2cff66 to e602cbc Compare April 25, 2025 12:47
@github-actions
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3534
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161160

@github-actions
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3534
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161160

@alperozturk96
Copy link
Contributor Author

alperozturk96 commented Apr 25, 2025

@tobiasKaminsky Any idea why these tests are failing? Only the logic for HTTP codes 400, 403, or 415 has been changed.

Screenshot 2025-04-25 at 15 48 44

@alperozturk96 alperozturk96 force-pushed the bugfix/xml-exception-parser branch from e570fb8 to 50f678b Compare May 7, 2025 06:45
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025

SpotBugs

CategoryBaseNew
Bad practice3534
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161160

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025

SpotBugs

CategoryBaseNew
Bad practice3534
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161160

@nextcloud-android-bot
Copy link
Collaborator

tobiasKaminsky
tobiasKaminsky previously approved these changes May 7, 2025
ZetaTom
ZetaTom previously approved these changes May 7, 2025
Copy link
Contributor

@ZetaTom ZetaTom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything worked as expected during testing.

I would suggest removing the duplicate test case that was there before.

@alperozturk96 alperozturk96 dismissed stale reviews from ZetaTom and tobiasKaminsky via 3054ee4 May 7, 2025 08:54
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025

SpotBugs

CategoryBaseNew
Bad practice3534
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161160

@nextcloud-android-bot
Copy link
Collaborator

@nextcloud-android-bot
Copy link
Collaborator

alperozturk96 and others added 7 commits May 28, 2025 12:32
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
…ParserTests.kt

Co-authored-by: Tom <[email protected]>
Signed-off-by: Alper Öztürk <[email protected]>
@alperozturk96 alperozturk96 force-pushed the bugfix/xml-exception-parser branch from 3054ee4 to 3c3f433 Compare May 28, 2025 04:32
@github-actions
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3534
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161160

@codecov
Copy link

codecov bot commented May 28, 2025

Codecov Report

Attention: Patch coverage is 9.09091% with 40 lines in your changes missing coverage. Please review.

Project coverage is 43.01%. Comparing base (2d47aa4) to head (3c3f433).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
...mon/utils/responseFormat/ResponseFormatDetector.kt 0.00% 27 Missing ⚠️
...d/lib/common/operations/RemoteOperationResult.java 0.00% 10 Missing ⚠️
.../lib/common/utils/responseFormat/ResponseFormat.kt 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1713      +/-   ##
============================================
- Coverage     43.20%   43.01%   -0.19%     
+ Complexity      981      979       -2     
============================================
  Files           229      231       +2     
  Lines          8490     8525      +35     
  Branches       1109     1115       +6     
============================================
- Hits           3668     3667       -1     
- Misses         4317     4353      +36     
  Partials        505      505              
Files with missing lines Coverage Δ
...roid/lib/common/operations/XMLExceptionParser.java 67.34% <100.00%> (ø)
.../lib/common/utils/responseFormat/ResponseFormat.kt 0.00% <0.00%> (ø)
...d/lib/common/operations/RemoteOperationResult.java 0.00% <0.00%> (ø)
...mon/utils/responseFormat/ResponseFormatDetector.kt 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tobiasKaminsky tobiasKaminsky merged commit cb9ebaa into master Jun 2, 2025
17 of 19 checks passed
@tobiasKaminsky tobiasKaminsky deleted the bugfix/xml-exception-parser branch June 2, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants