-
Notifications
You must be signed in to change notification settings - Fork 94
BugFix - XML Exception Parser #1713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c2cff66 to
e602cbc
Compare
|
@tobiasKaminsky Any idea why these tests are failing? Only the logic for HTTP codes 400, 403, or 415 has been changed. |
e570fb8 to
50f678b
Compare
|
stable-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/4060-IT-stable-07-09/debug/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything worked as expected during testing.
I would suggest removing the duplicate test case that was there before.
library/src/androidTest/java/com/owncloud/android/XMLExceptionParserTests.kt
Outdated
Show resolved
Hide resolved
|
master-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/4061-IT-master-09-12/debug/ |
|
stable-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/4061-IT-stable-09-13/debug/ |
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
…ParserTests.kt Co-authored-by: Tom <[email protected]> Signed-off-by: Alper Öztürk <[email protected]>
3054ee4 to
3c3f433
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1713 +/- ##
============================================
- Coverage 43.20% 43.01% -0.19%
+ Complexity 981 979 -2
============================================
Files 229 231 +2
Lines 8490 8525 +35
Branches 1109 1115 +6
============================================
- Hits 3668 3667 -1
- Misses 4317 4353 +36
Partials 505 505
🚀 New features to boost your workflow:
|

Fixes
Unexpected token (position:TEXT {"ocs":{"meta":{...@1:97 in [java.io](http://java.io/).InputStreamReader@23ca098)