Skip to content

Conversation

@alperozturk96
Copy link
Contributor

@alperozturk96 alperozturk96 commented Mar 6, 2025

Fresh Install

fresh_sha256.mp4

Upgrade from 3.30.8

upgrade_from_3.30.8.mp4

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@alperozturk96 alperozturk96 changed the title Use SHA256 Use SHA-256 Mar 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
@github-actions
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Copy link
Member

@tobiasKaminsky tobiasKaminsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please test

  • create CSR with Android
  • private/public key is generated and stored on server
  • Desktop and iOS needs to understand it / be able to add it as new account

@github-actions
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3434
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness1111
Performance88
Total168168

@codecov
Copy link

codecov bot commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.82%. Comparing base (882bc10) to head (0f9e107).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1683      +/-   ##
============================================
+ Coverage     42.80%   42.82%   +0.01%     
- Complexity      976      979       +3     
============================================
  Files           233      234       +1     
  Lines          8564     8570       +6     
  Branches       1120     1120              
============================================
+ Hits           3666     3670       +4     
- Misses         4394     4395       +1     
- Partials        504      505       +1     
Files with missing lines Coverage Δ
...m/owncloud/android/lib/resources/e2ee/CsrHelper.kt 100.00% <100.00%> (ø)
...d/android/lib/resources/e2ee/SignatureAlgorithm.kt 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alperozturk96
Copy link
Contributor Author

All tests between clients have been completed.

@alperozturk96 alperozturk96 enabled auto-merge August 1, 2025 11:49
@alperozturk96 alperozturk96 dismissed tobiasKaminsky’s stale review August 1, 2025 11:49

All tests between clients have been completed.

@alperozturk96 alperozturk96 merged commit db3f2b5 into master Aug 1, 2025
19 checks passed
@alperozturk96 alperozturk96 deleted the use-sha256 branch August 1, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants