Skip to content

Add sc_locked status #1446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2024
Merged

Add sc_locked status #1446

merged 1 commit into from
May 3, 2024

Conversation

@alperozturk96
Copy link
Contributor

@alperozturk96 alperozturk96 commented May 3, 2024

No description provided.

@alperozturk96
add sc_locked status
c90b01c 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 alperozturk96 mentioned this pull request May 3, 2024
Merged
1 task
@codecov
Copy link

codecov bot commented May 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 17.64706% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 48.98%. Comparing base (c853827) to head (c90b01c).

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1446      +/-   ##
============================================
- Coverage     48.99%   48.98%   -0.01%     
- Complexity      996      997       +1     
============================================
  Files           206      206              
  Lines          7828     7835       +7     
  Branches       1018     1019       +1     
============================================
+ Hits           3835     3838       +3     
- Misses         3444     3448       +4     
  Partials        549      549
Files Coverage Δ
...d/lib/common/operations/RemoteOperationResult.java 44.25% <17.64%> (-0.62%) ⬇️

... and 1 file with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2024

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@alperozturk96 alperozturk96 enabled auto-merge May 3, 2024 09:35
AndyScherzinger
AndyScherzinger approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alperozturk96 alperozturk96 merged commit f642036 into master May 3, 2024
@delete-merged-branch delete-merged-branch bot deleted the feature/handle-file-locked-status branch May 3, 2024 11:03
@AndyScherzinger AndyScherzinger added this to the NC Android lib 2.20.0 milestone May 3, 2024
ZetaTom added a commit that referenced this pull request May 16, 2024
@ZetaTom
Manual backport of #1446
f2156b6 
Signed-off-by: ZetaTom <[email protected]>
ZetaTom added a commit that referenced this pull request May 29, 2024
@ZetaTom
Manual backport of #1446
2a268a5 
Signed-off-by: ZetaTom <[email protected]>
ZetaTom added a commit that referenced this pull request May 30, 2024
@ZetaTom
Manual backport of #1446
df31309 
Signed-off-by: ZetaTom <[email protected]>
ZetaTom added a commit that referenced this pull request Jun 3, 2024
@ZetaTom
Manual backport of #1446
0e25b84 
Signed-off-by: ZetaTom <[email protected]>
ZetaTom added a commit that referenced this pull request Jun 12, 2024
@ZetaTom
Manual backport of #1446
db72c56 
Signed-off-by: ZetaTom <[email protected]>
ZetaTom added a commit that referenced this pull request Jun 17, 2024
@ZetaTom
Manual backport of #1446
c2a99c0 
Signed-off-by: ZetaTom <[email protected]>
ZetaTom added a commit that referenced this pull request Jun 18, 2024
@ZetaTom
Manual backport of #1446
138a855 
Signed-off-by: ZetaTom <[email protected]>
ZetaTom added a commit that referenced this pull request Jun 24, 2024
@ZetaTom
Manual backport of #1446
25735f5 
Signed-off-by: ZetaTom <[email protected]>
tobiasKaminsky pushed a commit that referenced this pull request Jun 26, 2024
@ZetaTom @tobiasKaminsky
Manual backport of #1446
ee68c80 
Signed-off-by: ZetaTom <[email protected]>
@alperozturk96
Copy link
Contributor Author

alperozturk96 commented Aug 9, 2024

/backport to stable-2.19

@backportbot backportbot bot mentioned this pull request Aug 9, 2024
Merged
tobiasKaminsky pushed a commit that referenced this pull request Aug 16, 2024
@ZetaTom @tobiasKaminsky
Manual backport of #1446
eefafa6 
Signed-off-by: ZetaTom <[email protected]>
tobiasKaminsky pushed a commit that referenced this pull request Aug 20, 2024
@ZetaTom @tobiasKaminsky
Manual backport of #1446
156be2f 
Signed-off-by: ZetaTom <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

NC Android lib 2.20.0

Development

Successfully merging this pull request may close these issues.

3 participants

@alperozturk96 @AndyScherzinger